After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695052 - Property org.freedesktop.Secret.Item.Created is zero for all secrets
Property org.freedesktop.Secret.Item.Created is zero for all secrets
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-03 13:37 UTC by Dmitry Shachnev
Modified: 2013-03-05 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Refactor out testing code for starting gnome-keyring-daemon (25.74 KB, patch)
2013-03-05 11:46 UTC, Stef Walter 		committed Details | Review
secret-store: Update the Created and Modified properties correctly (16.29 KB, patch)
2013-03-05 11:46 UTC, Stef Walter 		committed Details | Review

Description Dmitry Shachnev 2013-03-03 13:37:40 UTC 
As the summary says, secret's Created property is always zero, while Modified works. Best observed with QDbus:

$ qdbus org.freedesktop.secrets /org/freedesktop/secrets/collection/login/400 org.freedesktop.Secret.Item.Created 
0
$ qdbus org.freedesktop.secrets /org/freedesktop/secrets/collection/login/400 org.freedesktop.Secret.Item.Modified 
1352020459

This is observed on two different machines (one running Ubuntu, another Debian), with gnome-keyring 3.6.2.
Comment 1 Stef Walter 2013-03-05 11:46:01 UTC 
Created attachment 238118 [details] [review]
dbus: Refactor out testing code for starting gnome-keyring-daemon

This is going to be used by many later tests
Comment 2 Stef Walter 2013-03-05 11:46:07 UTC 
Created attachment 238119 [details] [review]
secret-store: Update the Created and Modified properties correctly

 * Set the Modified property before committing transactions
 * Set the Created property when items and collections are created
 * Add tests for this functionality
Comment 3 Stef Walter 2013-03-05 11:47:01 UTC 
Dmitry, could you review these patches before I push them to git master?
Comment 4 Dmitry Shachnev 2013-03-05 14:55:22 UTC 
It works now, thanks!
Comment 5 Dmitry Shachnev 2013-03-05 14:55:39 UTC 
Review of attachment 238118 [details] [review]:

+1
Comment 6 Dmitry Shachnev 2013-03-05 14:56:00 UTC 
Review of attachment 238119 [details] [review]:

Great work!
Comment 7 Stef Walter 2013-03-05 18:23:39 UTC 
Attachment 238118 [details] pushed as 527da9c - dbus: Refactor out testing code for starting gnome-keyring-daemon
Attachment 238119 [details] pushed as c90a1cc - secret-store: Update the Created and Modified properties correctly