GNOME Bugzilla – Bug 695047
sundry: Add Power Statistics & Personal File Sharing
Last modified: 2021-05-25 12:45:52 UTC
I strongly dislike the name "Sundry" and I'm not sure the idea makes sense; I guess you need to give the reviewers and haters something to criticize when GNOME 3.8 is released... ;) Anyway here's a patch: Also Debian keeps a rather extensive blacklist at http://anonscm.debian.org/viewvc/pkg-gnome/desktop/experimental/gnome-menus/debian/menus.blacklist?view=markup that may have items you want to add
Created attachment 237866 [details] [review] sundry: Add Power Statistics & Personal File Sharing These seem to sort of duplicate what we have in Settings. Perhaps the extra graphs and info from Power Statistics should find a new home in System Monitor?
(In reply to comment #0) > I strongly dislike the name "Sundry" and I'm not sure the idea > makes sense I agree that the name isn't the best, but I think that the idea of putting stuff like OpenJDK settings in a place where it's not part of the default applications view is a good one. Suggestions for the name are welcome, but I'd rather not bikeshed over it. > Also Debian keeps a rather extensive blacklist at > http://anonscm.debian.org/viewvc/pkg-gnome/desktop/experimental/gnome-menus/debian/menus.blacklist?view=markup > that may have items you want to add Wow, I didn't know about this. It's possible we should just adopt this entire list upstream and put a comment showing the source.
Review of attachment 237866 [details] [review]: ::: layout/gnome-applications.menu @@ +184,3 @@ <Filename>gnome-orca.desktop</Filename> + <Filename>gnome-power-statistics.desktop</Filename> + <Filename>gnome-user-share-properties.desktop</Filename> I don't have this one. Where does it come from?
(In reply to comment #3) > ::: layout/gnome-applications.menu > @@ +184,3 @@ > <Filename>gnome-orca.desktop</Filename> > + <Filename>gnome-power-statistics.desktop</Filename> > + <Filename>gnome-user-share-properties.desktop</Filename> > > I don't have this one. Where does it come from? http://git.gnome.org/browse/gnome-power-manager/tree/data/gnome-power-statistics.desktop.in.in And I guess I still had the old version of gnome-user-share installed so never mind that. (In reply to comment #2) > Suggestions for the name are welcome, but I'd rather not bikeshed over it. I think it would be simpler if we could re-use 'Other'. Otherwise, 'Miscellaneous' or 'Misc.' is a more common word.
Review of attachment 237866 [details] [review]: OK, I have gnome-power-statistics, so add that one. It looks like they renamed it to gnome-user-share.desktop, so feel free to add that one along with the -properties.desktop variant so we support old jhbuild systems.
I believe gnome-user-share.desktop is just the autostart file so we don't need to override it. Thanks! Attachment 237866 [details] pushed as 0f92935 - sundry: Add Power Statistics & Personal File Sharing
Ahem... gnome-power-statistics is an application (and a nice one). If you want it, you install it. If you don't like it, you remove it. We should not blacklist applications, even less so applications that are not installed by default.
Is 'Sundry' a blacklist? Then why do we blacklist Alacarte, dconf-editor, gconf-editor, Orca, etc. which are also nice apps for what they do. Why are we overriding categories for GNOME apps anyway instead of just fixing them at the source? The 'Sundry' feature is rather invasive and landed towards the end of the release cycle. I only got around to packaging gnome-menus 2 days ago for the Ubuntu GNOME3 PPA as usually it doesn't change dramatically....
(In reply to comment #8) > Is 'Sundry' a blacklist? Then why do we blacklist Alacarte, dconf-editor, > gconf-editor, Orca, etc. which are also nice apps for what they do. Why are we > overriding categories for GNOME apps anyway instead of just fixing them at the > source? The way I understood it, it is kind of a temporary blacklist, until we get rid of those desktop files (by replacing those configuration applets). In the ideal world, it would be completely empty. As for the examples mentioned: Orca is not an app, it would be autostarted by the desktop when needed; Alacarte is a replacement for the incompleteness of Software, and will go away eventually; gconf and dconf-editors are really hard core tweak tools, little better than command line gsettings, and don't need advertising. Also, we can't fix them at the source, because I doubt the authors of configuration applets would admit they are not the best possible application design, to use an euphemism. (Again, this is my understanding of Sundry. Jon, who introduced it, might have a different opinion)
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-menus/-/issues/ Thank you for your understanding and your help.