After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695020 - media-keys: Remove unused opcode property
media-keys: Remove unused opcode property
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-02 19:39 UTC by Florian Müllner
Modified: 2013-03-04 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Remove unused opcode property (1.31 KB, patch)
2013-03-02 19:39 UTC, Florian Müllner 		reviewed Details | Review
media-keys: Remove obsolete check for xinput2 (1.58 KB, patch)
2013-03-03 09:42 UTC, Florian Müllner 		none Details | Review
media-keys: Remove obsolete check for xinput2 (1.39 KB, patch)
2013-03-03 11:48 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-03-02 19:39:18 UTC 
Small drive-by fix, remove a left-over from the key-grab stuff ...
Comment 1 Florian Müllner 2013-03-02 19:39:21 UTC 
Created attachment 237838 [details] [review]
media-keys: Remove unused opcode property

We get it from supports_xinput2_devices(), but since commit b0cee1df30b4
we don't use it for anything anymore, so remove it.
Comment 2 Bastien Nocera 2013-03-02 23:27:32 UTC 
Review of attachment 237838 [details] [review]:

::: plugins/media-keys/gsd-media-keys-manager.c
@@ -2329,3 @@
         gnome_settings_profile_start (NULL);
 
-        if (supports_xinput2_devices (&manager->priv->opcode) == FALSE) {

We don't actually need to check for XI2 anymore at all, do we?

Might as well remove the check.
Comment 3 Florian Müllner 2013-03-03 09:42:27 UTC 
Created attachment 237868 [details] [review]
media-keys: Remove obsolete check for xinput2

Indeed ...
Comment 4 Florian Müllner 2013-03-03 11:48:43 UTC 
Created attachment 237872 [details] [review]
media-keys: Remove obsolete check for xinput2

Re-added input-helper include, it's still used.
Comment 5 Bastien Nocera 2013-03-04 10:37:43 UTC 
Review of attachment 237872 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2013-03-04 12:21:41 UTC 
Attachment 237872 [details] pushed as 1993de0 - media-keys: Remove obsolete check for xinput2