After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695003 - Entry's bg active state in pixmaps-engine is browken in 15 and 16.
Entry's bg active state in pixmaps-engine is browken in 15 and 16.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-02 15:59 UTC by Joshua Brown
Modified: 2013-03-05 23:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert "entry: never use GTK_STATE_ACTIVE to paint the background" (1.47 KB, patch)
2013-03-05 22:50 UTC, Cosimo Cecchi 		committed Details | Review
entry: add a state-hint-background style property (2.64 KB, patch)
2013-03-05 22:50 UTC, Cosimo Cecchi 		rejected Details | Review

Description Joshua Brown 2013-03-02 15:59:28 UTC 
Entry_bg detail within Flat_Box function of Active state is broken in 2.24.15 and 2.24.16.  The active state draws the default bg color as the background instead of honoring the defined settings.  The gtk2 adwaita theme is broken here but most noticeable within dark themes such as delorean-dark, and dorian-theme. This behavior doesn't exist in prior versions such as 14.
Comment 1 Cosimo Cecchi 2013-03-05 22:50:11 UTC 
Created attachment 238169 [details] [review]
Revert "entry: never use GTK_STATE_ACTIVE to paint the background"

This reverts commit 87115e00a81e9d6a2c4d18106af422765004fe2a.
Comment 2 Cosimo Cecchi 2013-03-05 22:50:15 UTC 
Created attachment 238170 [details] [review]
entry: add a state-hint-background style property

To avoid breaking compatibility with themes that have assumptions on the
behavior of the state-hint style property, add another property that can
be used to disable the state hint for the background only.
After this commit, the default behavior when state-hint is enabled is
the same of GTK 2.24.14.
Comment 3 Cosimo Cecchi 2013-03-05 22:52:16 UTC 
This is not pretty, but I don't see many alternatives if we want to keep compatibility with the old behavior.
Comment 4 Cosimo Cecchi 2013-03-05 23:03:13 UTC 
Actually I'm wrong; the latest Adwaita doesn't need commit 87115e00a81e9d6a2c4d18106af422765004fe2a to work properly, as we recently changed how we render the background for entries - I'm just going to revert it.
Comment 5 Cosimo Cecchi 2013-03-05 23:06:14 UTC 
Attachment 238169 [details] pushed as 3087e8b - Revert "entry: never use GTK_STATE_ACTIVE to paint the background"