After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694997 - Don't let the user trigger message-tray when in full screen.
Don't let the user trigger message-tray when in full screen.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.7.x
Other Linux
: Normal blocker
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-02 14:03 UTC by Alex Hultman
Modified: 2013-03-10 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Don't open by pressure when we have a full-screen window open (1.65 KB, patch)
2013-03-10 02:17 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
layout: Disable the overview hotcorner when we have a full-screen window open (1.96 KB, patch)
2013-03-10 02:18 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Alex Hultman 2013-03-02 14:03:57 UTC
From bug 683786:

> I don't like that you can trigger the message tray when in full screen.
> Games that did the old override-redirect flag couldn't get interfered by the
> message tray but now that we have games not setting this flag you can interrupt
> game play by placing the cursor at the bottom. It's totally inconsistent
> because you cannot trigger Activities hotspot when in full screen so why should
> you be able to trigger the message tray?
> 
> Games like Osmos that uses a mouse cursor shouldn't mess up just because you
> touched the lower edge of the screen during game play. Also - when watching
> YouTube full screen and you reach for the button to exit full screen you can
> trigger the message tray by mistake.

You seemed to have found a bug. The trigger here is going to be rewritten for
3.8, but I'll try and make a patch so that that doesn't happen in the mean
time...
[reply] [-] Comment 14 Alex Hultman 2012-12-08 08:25:29 UTC
(In reply to comment #13)
> You seemed to have found a bug. The trigger here is going to be rewritten for
> 3.8, but I'll try and make a patch so that that doesn't happen in the mean
> time...

Should I open a separate bug report for this? It's annoying and has been since
3.0.

Yet, when I now tested the beta out this is still an issue. It's inconsistent and disturbs game play.

Superkey + M should still work ofc (just like superkey does for triggering the overview). It's a mouse issue.
Comment 1 Alex Hultman 2013-03-09 21:46:11 UTC
Nothing on this yet? It will mess up any game in 3.8. I recently triggered message-tray during Puddle gameplay and I have done it in Osmos (two games from Steam). I'm shure you don't want gamers triggering the message-tray when playing Counter Strike? It's totally insane to have the Activities hotspot disabled in fullscreen yet have the message tray enabled. Inconsistent and wrong. Especially when 3.8 is having pressure sensitivity and no timeout like 3.6 This will mean if you play Counter Strike and quickly move the mouse cursor down you will trigger message-tray in the middle of trying to aim for someones head. Insanely bad gaming platform.

Jasper even said he should fix this when rewriting for XInput2 / pointer barriers.

If fullscreen then hinder message-tray. Fullscreen means "focus on app, not on platform". Super + M and Super keys should still work, ofc.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-10 02:17:41 UTC
Created attachment 238489 [details] [review]
messageTray: Don't open by pressure when we have a full-screen window open

When we have a full-screen window open, we expect the app to get all of
the chrome, so we should disable the bottom barrier as well.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-10 02:18:07 UTC
Created attachment 238490 [details] [review]
layout: Disable the overview hotcorner when we have a full-screen window open

For the same reasons that we disable the tray barrier, we should
disable hot corners as well -- when users have a full-screen game
open, we shouldn't allow overview activation by the hotcorner.


Sorry about that -- this is entirely my fault. I completely forgot
about this.
Comment 4 Alex Hultman 2013-03-10 02:28:02 UTC
No harm done if this lands in time for 3.8. It will be the best release ever :)
Comment 5 drago01 2013-03-10 08:48:12 UTC
Review of attachment 238489 [details] [review]:

OK.
Comment 6 drago01 2013-03-10 08:49:03 UTC
Review of attachment 238490 [details] [review]:

OK.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-03-10 16:00:33 UTC
Attachment 238489 [details] pushed as 73fa4b1 - messageTray: Don't open by pressure when we have a full-screen window open
Attachment 238490 [details] pushed as 29152d3 - layout: Disable the overview hotcorner when we have a full-screen window open