After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694990 - use primary icon slot for search icon
use primary icon slot for search icon
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-02 13:07 UTC by William Jon McCann
Modified: 2013-03-03 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Place the search icon in the primary slot of the entry (1.47 KB, patch)
2013-03-02 13:08 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-03-02 13:07:55 UTC 
Currently in the search entry we use the secondary icon slot for both the icon used to identify the entry and the icon used to clear it.
Comment 1 William Jon McCann 2013-03-02 13:08:40 UTC 
Created attachment 237790 [details] [review]
Place the search icon in the primary slot of the entry

Instead of using the secondary slot for both clear and search. This
Makes it possible to use the search icon for actions regardless of
whether text has been entered, makes it possible to use the primary
icon to indicate search status, allows us to indicate the purpose
of the entry even if text has been already entered.
Comment 2 Matthias Clasen 2013-03-03 01:40:37 UTC 
Review of attachment 237790 [details] [review]:

Looks good to me
Comment 3 William Jon McCann 2013-03-03 16:16:29 UTC 
Attachment 237790 [details] pushed as cb27c4b - Place the search icon in the primary slot of the entry