GNOME Bugzilla – Bug 694974
Don't special case the last position in the remote search order
Last modified: 2013-04-02 19:51:17 UTC
This is a follow up from https://bugzilla.gnome.org/show_bug.cgi?id=687491#c33 after that got closed. To me, special casing the last position is very unexpected, and if I didn't find that comment I would simple assume it was a very weird bug in the sorting function. Additionally, it causes misbehavior in the search panel, when dealing with a mix of sorted and unsorted items (which randomly become first or last in the list). I believe it is a lot simpler, logically and implementation-wise, to have explicitly sorted elements first, and then everything else in alphabetical order.
Created attachment 237770 [details] [review] RemoteSearch: don't sort the last explicitly sorted provider last It's a confusing semantic, and keeping it causes bugs in the control center panels.
Any comments on this? I'd like to solve the related control center bug before 3.8
What's the control-center bug? And you'd have to change the gsettings schema description as well.
I forgot to link it, it's bug 694975.
Review of attachment 237770 [details] [review]: The patch looks good to me; removing the special casing makes a lot of sense code-wise and semantically, but doesn't completely adhere to the suggested design. I think it's okay regardless, as long as we pay attention to keeping the default list in GSettings updated when new core applications gain a search provider. Like Jasper said, the gsettings-desktop-schemas key description should be updated as well; other than that, let's do this — if this really proves to be a problem in the future, we could introduce another different key to store one single value to go last if set. Up to the Shell and gnome-control-center maintainers to decide if they want it for 3.8 or only for master.
(In reply to comment #5) > Up to the Shell and gnome-control-center maintainers to decide if they > want it for 3.8 or only for master. For gnome-shell, master *is* 3.8. I'm fine with targeting 3.8.1.
Attachment 237770 [details] pushed as 78272e5 - RemoteSearch: don't sort the last explicitly sorted provider last