GNOME Bugzilla – Bug 694960
Improve search results
Last modified: 2013-03-01 23:16:22 UTC
In its current state, a search in the shell provides a different set of results than a search in the application, and neither one matches the encouraged search pattern (split by words, require each word to match, ... - TL;DR: do what shell does). Adjust both searches to follow this pattern.
Created attachment 237746 [details] [review] search-provider: Concatenate search terms with AND Currently the provider will match all panels that match at least one search term. This differs from the search pattern we use in GNOME Shell and other GNOME applications, where a result has to match all search terms. The latter allows users to narrow down search results by adding additional terms, which is generally more useful than potentially adding additional results.
Created attachment 237747 [details] [review] window: Split search into words Rather than using the search entry text as a single term when filtering panels, split the text into multiple terms and concatenate the results, which is consistent with the search provider and the encouraged search pattern for GNOME applications.
Review of attachment 237746 [details] [review]: Looks good.
Review of attachment 237747 [details] [review]: concatenate? Looks like subtract/refine to me. Code looks good.
(In reply to comment #4) > concatenate? Looks like subtract/refine to me. > Code looks good. What I mean: interpret a search for "foo bar baz" as "foo" AND "bar" AND "baz" (note how concatenation refers to search terms rather than results). Maybe something like "search-provider: Require all terms to match instead of any"?
(In reply to comment #5) > (In reply to comment #4) > > concatenate? Looks like subtract/refine to me. > > Code looks good. > > What I mean: interpret a search for "foo bar baz" as "foo" AND "bar" AND "baz" > (note how concatenation refers to search terms rather than results). Oh, scratch that - sorry, it's late :-)
Attachment 237746 [details] pushed as 4d01f6b - search-provider: Concatenate search terms with AND Attachment 237747 [details] pushed as ddba390 - window: Split search into words Pushed to master - is this something we want on 3-8 as well?
(In reply to comment #7) > Attachment 237746 [details] pushed as 4d01f6b - search-provider: Concatenate search terms > with AND > Attachment 237747 [details] pushed as ddba390 - window: Split search into words > > Pushed to master - is this something we want on 3-8 as well? Yes please
Pushed to gnome-3-8 as well, thanks!