After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694955 - Use GD_IS_ macros to validate input in public API
Use GD_IS_ macros to validate input in public API
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-01 20:31 UTC by jessevdk@gmail.com
Modified: 2013-03-01 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GD_IS_ macros to validate input in public API (4.97 KB, patch)
2013-03-01 20:31 UTC, jessevdk@gmail.com 		accepted-commit_now Details | Review

Description jessevdk@gmail.com 2013-03-01 20:31:41 UTC 
Some of the public API (mostly GdStack) checks for
NULL instead of using the GD_IS_ macros. This patch
adds use of GD_IS_ macros in public API where before
the object was checked simply against NULL.
Comment 1 jessevdk@gmail.com 2013-03-01 20:31:43 UTC 
Created attachment 237742 [details] [review]
Use GD_IS_ macros to validate input in public API
Comment 2 Cosimo Cecchi 2013-03-01 20:40:57 UTC 
Review of attachment 237742 [details] [review]:

Thanks, feel free to commit with this fixed.

::: libgd/gd-revealer.c
@@ +738,3 @@
                                      gint value)
 {
+  g_return_if_fail (GD_REVEALER (revealer));

GD_IS_REVEALER
Comment 3 jessevdk@gmail.com 2013-03-01 21:35:08 UTC 
Argh, lame mistake! Pushed with the fix, thanks!