After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694926 - Get rid of obsolete flags column.
Get rid of obsolete flags column.
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-01 11:22 UTC by Krzesimir Nowak
Modified: 2013-03-06 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removes flags column. (7.09 KB, patch)
2013-03-01 11:23 UTC, Krzesimir Nowak 		needs-work Details | Review
Removes flags column. v2 (10.12 KB, patch)
2013-03-04 13:42 UTC, Krzesimir Nowak 		none Details | Review
Removes flags column. v3 (9.95 KB, patch)
2013-03-04 14:26 UTC, Krzesimir Nowak 		committed Details | Review

Description Krzesimir Nowak 2013-03-01 11:22:19 UTC 
There is a flags column in object table. It was used by MediaExport's DBus service, but it is gone since 0.17.7.
Comment 1 Krzesimir Nowak 2013-03-01 11:23:12 UTC 
Created attachment 237698 [details] [review]
Removes flags column.

That patch is made against master + patch from bug 683926.
Comment 2 Krzesimir Nowak 2013-03-01 11:31:47 UTC 
Comment on attachment 237698 [details] [review]
Removes flags column.

Ignore the bug for now. I quickly wrote it, but actually forgot to test it.
Comment 3 Krzesimir Nowak 2013-03-01 11:33:47 UTC 
To read before making the patch: http://www.sqlite.org/faq.html#q11

Seems nowhere to be as simple as it could be. Hmpf.
Comment 4 Krzesimir Nowak 2013-03-04 13:42:10 UTC 
Created attachment 237982 [details] [review]
Removes flags column. v2

Now, current patch removes all indices and triggers related to object table, recreates it without flag column, readds triggers and indices and adds the is_guarded column. Maybe it could be done better, but my SQL skills are rusty at best.

The patch also removes related, now unused, functions and parameters.

My only concern is about using SQL strings from SQL factory as they may change in future. That could make in future upgrade path different from the one in time of writing this patch.
Comment 5 Krzesimir Nowak 2013-03-04 14:26:11 UTC 
Created attachment 237991 [details] [review]
Removes flags column. v3

It's the same as previous one, but just rebased against current master as there were some conflicts.
Comment 6 Jens Georg 2013-03-06 11:01:42 UTC 
(In reply to comment #4)
> Created an attachment (id=237982) [details] [review]
> Removes flags column. v2
> 
> Now, current patch removes all indices and triggers related to object table,
> recreates it without flag column, readds triggers and indices and adds the
> is_guarded column. Maybe it could be done better, but my SQL skills are rusty
> at best.
> 
> The patch also removes related, now unused, functions and parameters.
> 
> My only concern is about using SQL strings from SQL factory as they may change
> in future. That could make in future upgrade path different from the one in
> time of writing this patch.

That shouldn't matter IMHO.