After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694906 - search: fix description of results
search: fix description of results
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-28 23:17 UTC by Giovanni Campagna
Modified: 2013-02-28 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
search: fix description of results (2.28 KB, patch)
2013-02-28 23:17 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-02-28 23:17:19 UTC
"description" is documented as a valid field for search result metas,
and ListSearchResults implements it, so pass it down to be used.
Also, don't wrap the description in quotes, so that the search provider
can decide if it is an excerpt from the searched text or something else.
And to that extent, set use_markup to true, so that terms can be
highlighted.
Comment 1 Giovanni Campagna 2013-02-28 23:17:23 UTC
Created attachment 237663 [details] [review]
search: fix description of results
Comment 2 Cosimo Cecchi 2013-02-28 23:25:49 UTC
Review of attachment 237663 [details] [review]:

Looks good to me. Are you adding support for this to some app? :)
Comment 3 Giovanni Campagna 2013-02-28 23:36:21 UTC
control-center already has support, and seahorse will (bug 694606).
Comment 4 Giovanni Campagna 2013-02-28 23:39:34 UTC
Attachment 237663 [details] pushed as e788673 - search: fix description of results