After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694905 - Layout: don't minimize fullscreen windows that are focused
Layout: don't minimize fullscreen windows that are focused
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-28 23:03 UTC by Giovanni Campagna
Modified: 2013-03-01 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Layout: don't minimize fullscreen windows that are focused (1.90 KB, patch)
2013-02-28 23:03 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-02-28 23:03:23 UTC 
It happens from time to time that I have override redirect windows
that are not apparently related to any running application (xkill doesn't
tear down anything visible).
They are 1x1 and 1px outside the screen, just like those created by
meta_screen_create_offscreen_window(), but they're not in the same
XID range as the running shell.
Because they're override redirect, they're at the top of the stack,
so when these appears I can no longer use fullscreen windows. This patch
is mostly a workaround for that.
Comment 1 Giovanni Campagna 2013-02-28 23:03:26 UTC 
Created attachment 237662 [details] [review]
Layout: don't minimize fullscreen windows that are focused

Windows can sometimes be focused, or appear to be focused, without being
at the exact top of the stack, for example in the case of override-redirect
windows, or with attached modal dialogs. In that case, we should not
try to minimize them (as it creates a loop that makes it impossible to restore
the window)
Comment 2 drago01 2013-03-01 11:11:27 UTC 
Review of attachment 237662 [details] [review]:

Makes sense and should also fix bug 694547
Comment 3 drago01 2013-03-01 11:12:44 UTC 
(In reply to comment #2)
> Review of attachment 237662 [details] [review]:
> 
> Makes sense and should also fix bug 694547

Hmm not sure about bug 694547 after thinking about it ... but well this patch fixes at least this bug so ok.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-03-01 16:40:23 UTC 
Review of attachment 237662 [details] [review]:

Doesn't seem to be on top of master with the log statement -- I assume you'll rebase?
Comment 5 Giovanni Campagna 2013-03-01 17:23:51 UTC 
Attachment 237662 [details] pushed as b6bf8d5 - Layout: don't minimize fullscreen windows that are focused