GNOME Bugzilla – Bug 694888
region: formats field is empty
Last modified: 2013-03-13 14:50:28 UTC
We should not show an 'empty' field - if the formats setting is the same as the language, we should just repeat the same name.
This setting has no default value and only gets set if the user explicitly sets it in g-c-c. I think gnome-initial-setup should take care of setting it but we can certainly show something better than 'empty' using one of the current LC_ env vars when the setting is empty.
It should show the resulting inherited values instead of "None". (In reply to comment #1) <snip> > using one of the current LC_ > env vars when the setting is empty. Not using the current LC_. It should be based on the future value. If the region GSettings key is empty and you change the language, the value that shows should be based on the new language, not the current one.
Created attachment 238492 [details] [review] region: Display current locale country in formats if setting is empty
Review of attachment 238492 [details] [review]: Looks good to me
Review of attachment 238492 [details] [review]: That's based on the current language rather than the future language.
(In reply to comment #5) > Review of attachment 238492 [details] [review]: > > That's based on the current language rather than the future language. This only applies when we read the gsetting and it's set to "". After the user chooses a new locale from the dialog, priv->region get's updated and the label will reflect that.
Created attachment 238587 [details] [review] region: Display current locale country in formats if setting is empty -- Discussed this with Bastien on IRC. We should instead display the Language locale for Formats if the latter is not explicitly set since that's what will be applied after the user logs in again.
Review of attachment 238587 [details] [review]: Looks good.
Attachment 238587 [details] pushed as aba3cb9 - region: Display current locale country in formats if setting is empty