After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694887 - don't say 'None'
don't say 'None'
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-28 17:48 UTC by Matthias Clasen
Modified: 2013-03-12 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: Remove the "none" input source row when adding a real one (1.24 KB, patch)
2013-03-10 03:17 UTC, Rui Matos
committed Details | Review
region: Improve explanation when there are no input sources (929 bytes, patch)
2013-03-10 03:17 UTC, Rui Matos
committed Details | Review

Description Matthias Clasen 2013-02-28 17:48:25 UTC
when I go to the login screen tab, with no prior configuration, the input sources list just says 'None' - that is not great, it should probably have a more complete explanation there, like 'No input source selected'. Also, the string should go away when I add an input source. Currently, the 'None' sticks around.
Comment 1 Bastien Nocera 2013-03-01 10:13:28 UTC
During the demo, to be fair, we saw an SELinux warning popup, which I guess is related to this problem.

We have code in gnome-settings-daemon to deduce input sources from the locale. If the locale is set correctly for the system[1], we should be able to find out the input source to use and not have "None" in the list.

[1]: gdbus introspect --system --dest org.freedesktop.locale1  --object-path /org/freedesktop/locale1
Comment 2 Rui Matos 2013-03-10 03:17:45 UTC
Created attachment 238498 [details] [review]
region: Remove the "none" input source row when adding a real one
Comment 3 Rui Matos 2013-03-10 03:17:52 UTC
Created attachment 238499 [details] [review]
region: Improve explanation when there are no input sources
Comment 4 Matthias Clasen 2013-03-11 03:08:09 UTC
Review of attachment 238498 [details] [review]:

Looks ok.
Comment 5 Matthias Clasen 2013-03-11 03:08:49 UTC
Review of attachment 238499 [details] [review]:

Looks good to me. Rui, can you ask for a freeze break for this ? it has a new string...
Comment 6 Bastien Nocera 2013-03-11 09:45:35 UTC
Review of attachment 238498 [details] [review]:

::: panels/region/cc-region-panel.c
@@ +708,3 @@
+                if (l && l->next == NULL &&
+                    g_strcmp0 (g_object_get_data (G_OBJECT (l->data), "type"), "none") == 0)
+                        gtk_container_remove (GTK_CONTAINER (priv->input_list), GTK_WIDGET (l->data));

Why do we add this child in the first place?
Comment 7 Bastien Nocera 2013-03-11 09:46:51 UTC
Review of attachment 238499 [details] [review]:

I don't understand how we could be getting no input sources.
g-s-d should create a new source based on language when you remove the last one...
Comment 8 Rui Matos 2013-03-11 10:56:03 UTC
(In reply to comment #7)
> I don't understand how we could be getting no input sources.
> g-s-d should create a new source based on language when you remove the last
> one...

This only happens to the system (aka login) sources. Those aren't backed by gsettings but by xorg.conf instead so we just have to cope with whatever localed tells us.
Comment 9 Rui Matos 2013-03-12 14:01:07 UTC
Comment on attachment 238499 [details] [review]
region: Improve explanation when there are no input sources

Got i18n approval:
https://mail.gnome.org/archives/gnome-i18n/2013-March/msg00086.html

Attachment 238499 [details] pushed as a5fcef6 - region: Improve explanation when there are no input sources
Comment 10 Rui Matos 2013-03-12 14:02:39 UTC
Comment on attachment 238498 [details] [review]
region: Remove the "none" input source row when adding a real one

Pushed too