GNOME Bugzilla – Bug 694886
CLUTTER_ENABLE_ACCESSIBILITY is not checked
Last modified: 2021-06-10 11:32:36 UTC
At the running clutter documentation [1] it is mentioned that EnableAccessibility configuration file is equivalent to envvar CLUTTER_ENABLE_ACCESSIBILITY. Specifically: "EnableAccessibility: A boolean value, equivalent to setting CLUTTER_ENABLE_ACCESSIBILITY." Anyway that envvar is not checked, and not listed at the available environment variables. FWIW, this envvar could be needed due clutter-gtk. [1] http://developer.gnome.org/clutter/unstable/running-clutter.html
Created attachment 237633 [details] [review] Check for CLUTTER_ENABLE_ACCESSIBILITY envvar
Created attachment 237634 [details] [review] Extra documentation for CLUTTER_ENABLE_ACCESSIBILITY envvar
Review of attachment 237633 [details] [review]: ::: clutter/clutter-main.c @@ +1778,3 @@ + env_string = g_getenv ("CLUTTER_ENABLE_ACCESSIBILITY"); + if (g_strcmp0 (env_string, "false") == 0) we don't use 'false' or 'true' for most of our environment variables. checking for '0' should be fine: if (env_string != NULL && *env_string == '0') clutter_enable_accessibility = FALSE;
Review of attachment 237634 [details] [review]: ::: doc/reference/clutter/running-clutter.xml @@ +104,3 @@ + <listitem> + <para>Enables loading the accessibility support for + clutter. Default value: true. Valid values are: true or a11y is not loaded, and the way to disable it should be to just set the envvar to 0; so, I'd say: Enables the accessibility support inside Clutter. Default: enabled. To disable, set to 0.
Created attachment 237691 [details] [review] Check for CLUTTER_ENABLE_ACCESSIBILITY envvar Updated patch, based on previous review
Created attachment 237692 [details] [review] Extra documentation for CLUTTER_ENABLE_ACCESSIBILITY envvar Updated patch based on previous review
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of clutter, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a ticket at https://gitlab.gnome.org/GNOME/clutter/-/issues/ Thank you for your understanding and your help.