After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694828 - Shuffle some initialization code around
Shuffle some initialization code around
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-28 00:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-28 01:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
context: Move SetCStringsAreUTF8 to class_init (1.79 KB, patch)
2013-02-28 00:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
context: Do other one-time init stuff in class_init (1.71 KB, patch)
2013-02-28 00:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-28 00:06:02 UTC 
This puts it in more inline with what the rest of the code is
doing, and fixes an issue where we'd append to the GI search
path if more than one context was created.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-28 00:06:05 UTC 
Created attachment 237572 [details] [review]
context: Move SetCStringsAreUTF8 to class_init

Rather than use g_once_init_enter, simply use the standard
place for the one-time initialization sequence.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-28 00:06:08 UTC 
Created attachment 237573 [details] [review]
context: Do other one-time init stuff in class_init
Comment 3 Colin Walters 2013-02-28 00:24:03 UTC 
Review of attachment 237572 [details] [review]:

Ok.
Comment 4 Colin Walters 2013-02-28 00:25:22 UTC 
Review of attachment 237573 [details] [review]:

Looks good to me.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-28 01:21:18 UTC 
Attachment 237572 [details] pushed as cd3f528 - context: Move SetCStringsAreUTF8 to class_init
Attachment 237573 [details] pushed as 5745453 - context: Do other one-time init stuff in class_init