After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694825 - possibly add annotation for "consumes floating ref" params
possibly add annotation for "consumes floating ref" params
Status: RESOLVED DUPLICATE of bug 657202
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-27 22:52 UTC by Emanuele Aina
Modified: 2015-02-07 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: Annotate some GVariant parameters as (transfer full) (5.09 KB, patch)
2013-02-27 22:52 UTC, Emanuele Aina 		none Details | Review

Description Emanuele Aina 2013-02-27 22:52:29 UTC 
For convenience GVariant parameters are usually _ref_sink'ed to allow
inline calls to g_variant_new() (and family). Make this obvious by
from a documentation standpoint adding a (transfer full) annotation
where appropriate.
Comment 1 Emanuele Aina 2013-02-27 22:52:33 UTC 
Created attachment 237569 [details] [review]
gio: Annotate some GVariant parameters as (transfer full)
Comment 2 Allison Karlitskaya (desrt) 2013-02-28 13:31:46 UTC 
I think this is very much the wrong thing to do...

For the floating case, there is no transfer here because you were never considered to own a reference in the first place.

For the non-floating case, this is definitely not (transfer full) because you keep your own reference.


It might make sense to have some sort of common annotation for "this consumes a floating ref" but it's definitely not "(transfer full)".  Punting this over to introspection as more of a 'general enhancement' type of bug.
Comment 3 Emmanuele Bassi (:ebassi) 2013-08-27 10:44:35 UTC 
duplicate of bug 657202

*** This bug has been marked as a duplicate of bug 657202 ***
Comment 4 André Klapper 2015-02-07 17:00:19 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]