After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694815 - Continue streaming even if HEAD is not supported
Continue streaming even if HEAD is not supported
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-27 19:47 UTC by Anders d
Modified: 2013-04-13 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
renderer: Continue if server does not support HEAD (1.58 KB, patch)
2013-03-08 19:05 UTC, Jens Georg
committed Details | Review
Regenerated C file for 0.17.9 tarball (24.51 KB, text/x-vala)
2013-03-10 21:47 UTC, Jens Georg
  Details
Generated C file for 0.17.9 tarball (96.19 KB, text/x-csrc)
2013-03-12 08:00 UTC, Jens Georg
  Details
gst player with enanced error message (56.43 KB, text/x-csrc)
2013-03-18 10:29 UTC, Jens Georg
  Details

Description Anders d 2013-02-27 19:47:20 UTC
Today rygel will stop streaming if HEAD is not supported by the stream.

It would be better if rygel continued streaming even if HEAD is not supported by the stream.
Comment 1 Jens Georg 2013-03-08 19:05:22 UTC
Created attachment 238392 [details] [review]
renderer: Continue if server does not support HEAD
Comment 2 Jens Georg 2013-03-08 19:05:38 UTC
Does this help?
Comment 3 Anders d 2013-03-10 19:19:32 UTC
Im trying this patch on 0.17-7 from source package. But cant get it to build.

I downloaded 0.17-7 from ftp.gnome.

applied the patch and run configure and make. It gives me

make[3]: Entering directory `/home/anders/Downloads/rygel-0.17.7/src/librygel-renderer'
  VALAC  librygel_renderer_2_0_la_vala.stamp
rygel-player-controller.vala:63.19-63.36: error: only automatic properties can have default values
        default = "NO_MEDIA_PRESENT";
                  ^^^^^^^^^^^^^^^^^^
rygel-player-controller.vala:69.19-69.19: error: only automatic properties can have default values
        default = 0;
                  ^
rygel-player-controller.vala:75.19-75.20: error: only automatic properties can have default values
        default = "";
                  ^^
Compilation failed: 3 error(s), 0 warning(s)

which i strange i dont even modify that file..

is jhbuild the only option for building rygel?
Comment 4 Jens Georg 2013-03-10 20:38:41 UTC
Ehm ok, that's weird. Let me see if I can provide a C file. Probably the easiest option.
Comment 5 Jens Georg 2013-03-10 21:47:35 UTC
Created attachment 238545 [details]
Regenerated C file for 0.17.9 tarball
Comment 6 Anders d 2013-03-11 20:36:41 UTC
You are writing that you generate a c file but attached a vala file?

I get the same error with this vala file.

Without the patch rygel 17.9 (and .7) builds just fine.
Comment 7 Jens Georg 2013-03-12 08:00:54 UTC
Created attachment 238672 [details]
Generated C file for 0.17.9 tarball
Comment 8 Jens Georg 2013-03-12 08:01:28 UTC
Sorry :)
Comment 9 Anders d 2013-03-17 17:55:11 UTC
Ok. So im getting this error.

** (rygel:19532): WARNING **: rygel-playbin-player.vala:443: Error from GStreamer element playbin0: gsturidecodebin.c(1332): gen_source_element (): /GstPlayBin:playbin0/GstURIDecodeBin:uridecodebin1

** (rygel:19532): WARNING **: rygel-playbin-player.vala:446: Going to STOPPED state
Comment 10 Jens Georg 2013-03-18 10:29:04 UTC
Created attachment 239111 [details]
gst player with enanced error message

Ok, tested against Rygel with disabled HEAD support which worked.

Can you also replace this attached file which should give a more helpful error message? Thanks.
Comment 11 Anders d 2013-03-18 18:12:24 UTC
im getting this.

** (rygel:8974): WARNING **: rygel-playbin-player.vala:443: Error from GStreamer element playbin0: No URI handler implemented for "http".

** (rygel:8974): WARNING **: rygel-playbin-player.vala:446: Going to STOPPED state
Comment 12 Jens Georg 2013-03-18 19:41:48 UTC
(In reply to comment #11)
> im getting this.
> 
> ** (rygel:8974): WARNING **: rygel-playbin-player.vala:443: Error from
> GStreamer element playbin0: No URI handler implemented for "http".

Er what? does gst-inspect-1.0 souphttpsrc give you any result?
Comment 13 Anders d 2013-03-18 21:09:14 UTC
er hrm. I messed around a lot trying to build rygel(trying to figure out the compile problems) and missed to reinstall gstreamer1.0-pulseaudio after a purge of all gstreamer packages.

And It works. Streaming works perfect!
Comment 14 Anders d 2013-04-08 20:42:12 UTC
is this patch included in any release package yet?
Comment 15 Jens Georg 2013-04-09 07:40:24 UTC
No, but it will go into 0.18.1 which will be released next week
Comment 16 Jens Georg 2013-04-13 12:06:13 UTC
Attachment 238392 [details] pushed as 8e3331d - renderer: Continue if server does not support HEAD