After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694793 - Stop checking for pangox in configure.ac
Stop checking for pangox in configure.ac
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-27 11:03 UTC by Emilio Pozuelo Monfort
Modified: 2013-02-28 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Stop checking for pangox and X11 (1.47 KB, patch)
2013-02-27 11:05 UTC, Emilio Pozuelo Monfort 		none Details | Review
Stop checking for pangox and X11, take 2 (1.83 KB, patch)
2013-02-28 15:07 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2013-02-27 11:03:09 UTC 
Yelp doesn't use any of pangox (or pangoxft) or X11 directly, so there's no point checking for them in configure.ac

This is specially important now that pangox has been removed from pango (in pango 1.31.0).
Comment 1 Emilio Pozuelo Monfort 2013-02-27 11:05:24 UTC 
Created attachment 237508 [details] [review]
Stop checking for pangox and X11
Comment 2 Emilio Pozuelo Monfort 2013-02-28 15:07:26 UTC 
Created attachment 237611 [details] [review]
Stop checking for pangox and X11, take 2

15:12 <    shaunm> pochu: I'm trying to figure out why that check was in there in the first place
15:12 <    shaunm> git tells me it was to fix some compilation issues on Solaris

Probably back in the day yelp uses X11 directly, but it doesn't anymore. These are the includes in src/*.[ch] (only src/ was using X_LIBS), note that there are no X headers:

#include <config.h>
#include <gdk/gdkkeysyms.h>
#include <gdk/gdkx.h>
#include <gio/gio.h>
#include <gio/gsettingsbackend.h>
#include <glib/gi18n.h>
#include <glib.h>
#include <glib-object.h>
#include <gtk/gtk.h>
#include <locale.h>
#include <math.h>
#include <stdlib.h>

15:15 <    shaunm> pochu: also, you're dropping the AC_SUBST(X_LIBS), but X_LIBS is still referenced in src/Makefile.am

Fixed now, thanks!
Comment 3 Emilio Pozuelo Monfort 2013-02-28 16:18:24 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.