After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694792 - Stop checking for pangox in configure.ac
Stop checking for pangox in configure.ac
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-27 10:53 UTC by Emilio Pozuelo Monfort
Modified: 2013-02-28 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Stop checking for pangox (1.79 KB, patch)
2013-02-27 10:54 UTC, Emilio Pozuelo Monfort 		reviewed Details | Review
Use pkg-config to check for X11 libraries (3.42 KB, patch)
2013-02-28 17:34 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2013-02-27 10:53:12 UTC 
configure.ac currently checks for pangox to decide whether to check for X or not, depending on whether pangox already includes -lX11 et al or not. However gnome-session doesn't use pangox (or pangoxft or even pango) itself, so there's no point in doing this. Furthermore, pangox has been removed from pango in 1.31.0.

I propose to stop checking for pangox to decide whether to check for X, and just check for X inconditionally.
Comment 1 Emilio Pozuelo Monfort 2013-02-27 10:54:39 UTC 
Created attachment 237506 [details] [review]
Stop checking for pangox
Comment 2 Colin Walters 2013-02-28 16:47:53 UTC 
Review of attachment 237506 [details] [review]:

Hmm this is a bit messy.  This patch will fix a real problem, but if you want to clean things up even more, we could just rely on the fact that nowadays X.org modules come with pkg-config files, and just add "x11 xau" to our PKG_CHECK_MODULES, and drop the reliance on the autoconf AC_PATH_XTRA.
Comment 3 Emilio Pozuelo Monfort 2013-02-28 17:34:43 UTC 
Created attachment 237632 [details] [review]
Use pkg-config to check for X11 libraries

That makes more sense indeed. This revised version of the patch completely removes the AC_PATH_XTRA check and uses PKG_CHECK_MODULES. I've tried to be consistent and so I've added a check just for x11. Not so for xauth as that's already been checked together with xext.

(Not sure what needs xext tbh, but xauth is needed by gnome-session/gdm.c and gets it through XEXT_CFLAGS/LIBS. If xext isn't really needed nowadays I can make another patch to remove the xext check while leaving the xau one)
Comment 4 Colin Walters 2013-02-28 17:41:30 UTC 
Review of attachment 237632 [details] [review]:

This looks good.
Comment 5 Emilio Pozuelo Monfort 2013-02-28 17:46:31 UTC 
Thanks, pushed as f0063b9