After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694784 - Show the session list when needed
Show the session list when needed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 694733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-02-27 04:50 UTC by Matthias Clasen
Modified: 2013-02-28 02:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show the session list when needed (1.02 KB, patch)
2013-02-27 04:50 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2013-02-27 04:50:47 UTC 
The conditions for showing the user list were not properly inverted,
causing the session list to be hidden when it shouldn't.
Comment 1 Matthias Clasen 2013-02-27 04:50:49 UTC 
Created attachment 237494 [details] [review]
Show the session list when needed
Comment 2 Ray Strode [halfline] 2013-02-27 05:45:53 UTC 
Review of attachment 237494 [details] [review]:

::: js/gdm/loginDialog.js
@@ +754,3 @@
                            transition: 'easeOutQuad' });
 
+        if (!(this._user && this._user.is_logged_in()) || this._verifyingUser)

close. i think it's got to be:

if ((this._user && !this._user.is_logged_in()) || this.verifyingUser)

otherwise we'll continue showing the session list too early when clicking "Not Listed?"
Comment 3 Ray Strode [halfline] 2013-02-27 23:10:52 UTC 
(pushed with noted change)
Attachment 237494 [details] pushed as a7bb6a2 - Show the session list when needed
Comment 4 Ray Strode [halfline] 2013-02-28 02:33:22 UTC 
*** Bug 694733 has been marked as a duplicate of this bug. ***