After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694757 - build: Use separate GLIB_WARN_CFLAGS that can be overridden externally
build: Use separate GLIB_WARN_CFLAGS that can be overridden externally
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-02-26 16:47 UTC by Colin Walters
Modified: 2013-02-27 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-build-Use-separate-GLIB_WARN_CFLAGS-that-can-be-over.patch (6.39 KB, patch)
2013-02-26 16:48 UTC, Colin Walters
none Details | Review
0001-build-Add-disable-compile-warnings.patch (6.52 KB, patch)
2013-02-26 21:13 UTC, Colin Walters
reviewed Details | Review

Description Colin Walters 2013-02-26 16:47:56 UTC
Some (broken) toolchains for example trip up
-Werror=missing-prototypes in system headers.  This patch allows
people to skip the formerly hardcoded "baseline" warnings by doing:

$ GLIB_WARN_CFLAGS="-Wall" ./configure ...
Comment 1 Colin Walters 2013-02-26 16:48:24 UTC
Created attachment 237460 [details] [review]
0001-build-Use-separate-GLIB_WARN_CFLAGS-that-can-be-over.patch
Comment 2 Colin Walters 2013-02-26 17:14:36 UTC
The other option is to add --disable-compile-warnings.  Thinking about this a bit more, maybe that is better.
Comment 3 Colin Walters 2013-02-26 21:13:36 UTC
Created attachment 237472 [details] [review]
0001-build-Add-disable-compile-warnings.patch
Comment 4 Dan Winship 2013-02-27 09:18:33 UTC
Comment on attachment 237472 [details] [review]
0001-build-Add-disable-compile-warnings.patch

>+AC_ARG_ENABLE(compile-warnings,

"more-warnings" seems to be the most common convention:

danw@laptop:gnome> grep -h 'AC_ARG_ENABLE.*warning' */configure.ac | sort | uniq -c
      1 AC_ARG_ENABLE(compile_warnings,
      2 AC_ARG_ENABLE(compile-warnings,
      1 AC_ARG_ENABLE(development, 	[  --enable-development    Enable any development warnings/incomplete code],	[development=$enableval],	[development="no"])
      2   AC_ARG_ENABLE([fatal-warnings],
      1 AC_ARG_ENABLE([gcc-warnings],
     12 AC_ARG_ENABLE(more-warnings,
      1 AC_ARG_ENABLE(warnings,

otherwise it looks good
Comment 5 Dan Winship 2013-02-27 09:19:36 UTC
although --enable/disable-compile-warnings makes more sense really, so if you want to declare the other modules to be wrong, I'd buy that. :)
Comment 6 Colin Walters 2013-02-27 13:31:30 UTC
(In reply to comment #5)
> although --enable/disable-compile-warnings makes more sense really, so if you
> want to declare the other modules to be wrong, I'd buy that. :)

I followed gnome-common, and I think it makes sense to unify more modules around that.