After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694742 - Fix possible memory leak when GlobalAlloc() fails
Fix possible memory leak when GlobalAlloc() fails
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-02-26 13:50 UTC by Aleksander Morgado
Modified: 2013-02-26 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for the issue. (1.04 KB, patch)
2013-02-26 13:52 UTC, Aleksander Morgado 		committed Details | Review

Description Aleksander Morgado 2013-02-26 13:50:12 UTC 
In _gdk_win32_window_change_property(), if GlobalAlloc() fails the 'wcptr' pointer should get freed. Instead, the code is freeing a NULL 'buf' variable which is nowhere else used.
Comment 1 Aleksander Morgado 2013-02-26 13:52:34 UTC 
Created attachment 237441 [details] [review]
Patch for the issue.
Comment 2 Michael Natterer 2013-02-26 14:12:06 UTC 
Comment on attachment 237441 [details] [review]
Patch for the issue.

That looks correct.
Comment 3 Aleksander Morgado 2013-02-26 14:16:27 UTC 
Pushed to git master, gtk-2-24 and gtk-3-6.