After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694704 - small fix for finding app icons
small fix for finding app icons
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Web Applications
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-25 20:31 UTC by William Jon McCann
Modified: 2013-02-28 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Try more shortcut icon names (1.01 KB, patch)
2013-02-25 20:31 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2013-02-25 20:31:23 UTC
I noticed we don't always find shortcut icons for some sites.
Comment 1 William Jon McCann 2013-02-25 20:31:46 UTC
Created attachment 237390 [details] [review]
Try more shortcut icon names
Comment 2 Reinout van Schouwen 2013-02-26 23:56:51 UTC
Review of attachment 237390 [details] [review]:

Wouldn't a regexp be more suitable than trying all combinations of 'shortcut' and 'icon' exhaustively?
Comment 3 Xan Lopez 2013-02-27 17:52:21 UTC
Review of attachment 237390 [details] [review]:

Ok, although Reinouts makes a good point.