GNOME Bugzilla – Bug 694703
fallback to favicon instead of "upper left corner" image
Last modified: 2013-03-02 14:15:55 UTC
I don't think falling back to a snapshot of the upper-left corner of the page is suiting us very well. For one, many pages use a centered, reading-width column for content and the upper left is just blank. Even when it isn't blank it often doesn't have any distinguishing characteristics. And it isn't very well associated with the "brand" of the app/site. I think it would be better to fallback to showing a buttonized version of the favicon if it exists. I can't imagine many sites don't have anything like this.
Created attachment 237393 [details] [review] Fallback to favicon instead of page snapshot
Review of attachment 237393 [details] [review]: Looks good to me! ::: src/window-commands.c @@ +525,3 @@ + icon = webkit_favicon_database_try_get_favicon_pixbuf (webkit_get_favicon_database (), + page_uri, + } IIRC, if this fails you can ask the database to fetch the icon. But since this can only be accessed from a page already loaded, I suspect that you'll always get a favicon. I might be wrong though. @@ -519,1 @@ - snapshot = ephy_web_view_get_snapshot (data->view, x, y, w, h); I think we don't use anymore this method (besides, wk is gaining API for this). We should probably remove it.
Attachment 237393 [details] pushed as 8a00f5c - Fallback to favicon instead of page snapshot