After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694697 - [PATCH] cosmetic fix for configure.ac
[PATCH] cosmetic fix for configure.ac
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-25 19:17 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2015-04-30 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix checking alternative backends (2.14 KB, patch)
2013-02-25 19:17 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
don't print "no" twice (1.82 KB, patch)
2013-02-26 10:43 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2013-02-25 19:17:48 UTC
Created attachment 237380 [details] [review]
fix checking alternative backends

checking pkg-config is at least version 0.9.0... yes
checking for HARFBUZZ... no
checking for CoreText availability... no
checking for CAIRO... yes
checking which cairo font backends could be used... none
configure: Disabling cairo support
configure: error: *** Could not enable any backends.
*** Must have at least one backend to build Pango.

The issue seems to be that configure does not consider the alternative backend when the first one is not there.
Comment 1 Behdad Esfahbod 2013-02-26 01:42:45 UTC
But!  HarfBuzz is a requirement of the pangofc-based (ie. pangoft2, pangoxft, pangocairo-fc) backends.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2013-02-26 07:42:42 UTC
ok, is harfbuzz a hard requirement now. if so the AC_MESSAGE([no]) part should go, so that PKG_HECK_MODULES fails if it is not present at that point already (otherwise the AC_MESSAGE([no]) should become a ':' as in my patch to not say "no" twice).
Comment 3 Behdad Esfahbod 2013-02-26 07:46:58 UTC
There are three ways to get a useful pango backend:

  * win32 + cairo-win32

  * coretext + cairo-coretext

  * harfbuzz + fontconfig + freetype + anyof(pangoft2, pangoxft, pangocairo-ft)
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2013-02-26 10:36:31 UTC
okay, got it. Will simplify the patch to do the cosmetic AC_MESSAGE cleanup and will hunt for harfbuzz packages for ubuntu precise. no idea how I managed to built it in the past :/
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2013-02-26 10:43:20 UTC
Created attachment 237423 [details] [review]
don't print "no" twice 

are freetype/fontconfig optional if we're on linux (have_harfbuzz)? Just wonder if it should fail if those are missing (like now) or if I should add a ", :".
Comment 6 Behdad Esfahbod 2013-02-26 20:03:34 UTC
HarfBuzz is a new (since August?) dependency.

On Linux, to have *any* backend, you need the three of FreeType, Fontconfig, and HarfBuzz.  And then Xft and cairo-ft will enable more backends if available.
Comment 7 Behdad Esfahbod 2015-04-30 15:00:14 UTC
Fixed!