GNOME Bugzilla – Bug 694692
disable animations shouldn't be toggled with gsettings
Last modified: 2013-12-13 16:52:05 UTC
Instead of mucking with gsettings (which may not be writable), g-s-d should just change whether or not the disable-animations xsetting is exported when dealing with remote connections. We'll also need to fix gnome-shell to look at the xsetting instead of the gsetting.
*** Bug 701176 has been marked as a duplicate of this bug. ***
gnome-shell part has already been changed (it is now looking at gtk_enable_animation) but not gsd..
my mistake, gsd xsettings is now exporting the value of gsettings org.gnome.desktop.interface / enable-animations to Gtk/EnableAnimations xsettings. So, I guess we can close this bug report ?
no, it's always done what you've pointed out and should continue to. but in the case where it wants to disable animations itself based on detection, it shouldn't round trip through gsettings. gsettings aren't for runtime state, they're for user preferences.
This bug was probably the indirect cause of bug 700283...
*** Bug 705448 has been marked as a duplicate of this bug. ***
Created attachment 251196 [details] [review] remote-display: Merge plugin into XSettings We merge the remote display object into XSettings, so that we can override the enable-animations settings without modifying GSettings. This was especially problematic on startup, or when overriding user settings. UNTESTED
Somebody will need to look into the patch and fix this up before 3.10, as I won't be around to handle it. Frédéric's patch in bug 704402 will also need updating for the new code (which shouldn't be too hard to do :).
I can test it but not before last week of august..
Hopefully Ray or Ryan can take a look and see whether it's working as expected. The code compiles, and doesn't crash on a quick run.
Created attachment 257621 [details] [review] remote-display: Merge plugin into XSettings We merge the remote display object into XSettings, so that we can override the enable-animations settings without modifying GSettings. This was especially problematic on startup, or when overriding user settings. UNTESTED
Rebased the patch with Frederic's llvmpipe detection and the high-dpi patches that went in. Can somebody please test this?
Created attachment 257622 [details] [review] remote-display: Merge plugin into XSettings We merge the remote display object into XSettings, so that we can override the enable-animations settings without modifying GSettings. This was especially problematic on startup, or when overriding user settings. UNTESTED
Seems that I pushed this to master by mistake, might as well get testing in GNOME 3.11 releases shortly.
(In reply to comment #14) > Seems that I pushed this to master by mistake, might as well get testing in > GNOME 3.11 releases shortly. Any way for us to get this fixed in 3.8?
There are no plans to fix it for 3.8.
Ok I upgraded to Gnome 3.10. g-s-d 3.10.2 and gnome-shell 3.10.2.1 After disabling "enable-animations" it's still set on next logon. Already tried the patch above from Bastien Nocera but after that my icon themes and gtk2 themes were no longer applied.
(In reply to comment #17) > Ok I upgraded to Gnome 3.10. > g-s-d 3.10.2 and gnome-shell 3.10.2.1 It was fixed in GNOME 3.11, not 3.10.