After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694633 - Add a keyboard drawing widget
Add a keyboard drawing widget
Status: RESOLVED WONTFIX
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 694623
 
 
Reported: 2013-02-25 00:23 UTC by Giovanni Campagna
Modified: 2013-07-22 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a keyboard drawing widget (75.49 KB, patch)
2013-02-25 00:23 UTC, Giovanni Campagna
reviewed Details | Review
Add a keyboard drawing widget (71.25 KB, patch)
2013-02-26 17:29 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2013-02-25 00:23:00 UTC
Copied from libgnomekdb, which is now dead, and adapted for
gnome-desktop (mainly to remove the dependency on libxklavier
and to use the correct namespace)
Comment 1 Giovanni Campagna 2013-02-25 00:23:02 UTC
Created attachment 237318 [details] [review]
Add a keyboard drawing widget
Comment 2 Rui Matos 2013-02-25 15:46:21 UTC
Review of attachment 237318 [details] [review]:

Do you think we'll need this anywhere besides g-c-c? I'd like to avoid growing the gnome-desktop API beyond the strictly necessary so maybe we should just put it in g-c-c. Speaking of API, there are several public methods here which we don't have any use for so they could also be removed.
Comment 3 Giovanni Campagna 2013-02-26 17:08:30 UTC
The main reason for adding it to gnome-desktop is that the rest of the API dealing with Xkb live there, so it seemed consistent to have them in one place.

The other reason is that gnome-initial-setup will probably offer the same functionality in the layout chooser, and therefore use the widget too.

I mostly kept the same public API as libgnomekbd, only removing what was confusing or unbindable, but I'm ok with reducing it to the bare minimum required by gnome-control-center/gnome-initial-setup.
Comment 4 Giovanni Campagna 2013-02-26 17:29:23 UTC
Created attachment 237462 [details] [review]
Add a keyboard drawing widget

Copied from libgnomekdb, which is now dead, and adapted for
gnome-desktop (mainly to remove the dependency on libxklavier
and to use the correct namespace)

Ok, this is a stripped down version. I removed the version
loading an explicit Xkb keyboard, and I removed modifier tracking
(as I didn't make sense to me)
Comment 5 Giovanni Campagna 2013-03-27 17:22:27 UTC
Attachment 237462 [details] pushed as c8d0413 - Add a keyboard drawing widget
Comment 6 Giovanni Campagna 2013-03-27 17:23:37 UTC
Sorry, pushed by mistake.
Comment 7 Bastien Nocera 2013-07-22 14:07:02 UTC
This should be a separate binary inside the gnome-control-center tree.