After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694626 - pango_font_map_get_serial() issues
pango_font_map_get_serial() issues
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-24 22:40 UTC by Behdad Esfahbod
Modified: 2013-02-28 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add pango_font_map_changed() (9.85 KB, patch)
2013-02-26 09:49 UTC, Alexander Larsson 		committed Details | Review
PangoFc: change FontMap in pango_fc_font_map_clear_cache() (766 bytes, patch)
2013-02-26 09:49 UTC, Alexander Larsson 		committed Details | Review

Description Behdad Esfahbod 2013-02-24 22:40:09 UTC 
1. Where's the matching pango_font_map_changed()?

2. pango_fc_font_map_clear_cache() should be calling the above changed() method.
Comment 1 Behdad Esfahbod 2013-02-24 23:56:41 UTC 
Alex, do you think you can take a look?
Comment 2 Alexander Larsson 2013-02-26 09:49:56 UTC 
Created attachment 237418 [details] [review]
Add pango_font_map_changed()

This is needed as a base class sometimes needs to invalidate
the fontmap.
Comment 3 Alexander Larsson 2013-02-26 09:49:59 UTC 
Created attachment 237419 [details] [review]
PangoFc: change FontMap in pango_fc_font_map_clear_cache()
Comment 4 Alexander Larsson 2013-02-26 09:51:26 UTC 
These are not very well tested, but seem ok. The reason we didn't add any pango_font_map_changed() before is that all the other invalidation points are in the backends themselves, and we missed this spot in a baseclass.
Comment 5 Behdad Esfahbod 2013-02-26 19:46:07 UTC 
Thanks Alex.  Please push.
Comment 6 Alexander Larsson 2013-02-27 13:58:16 UTC 
Attachment 237418 [details] pushed as c5f43d1 - Add pango_font_map_changed()
Attachment 237419 [details] pushed as 0b79a1f - PangoFc: change FontMap in pango_fc_font_map_clear_cache()
Comment 7 Alexander Larsson 2013-02-27 13:59:24 UTC 
Pushed to master. Should possibly also be backported to last stable release (with the function made private). Depends on what kind of release schedule you have and if some app hit this in practice.
Comment 8 Behdad Esfahbod 2013-02-28 00:48:03 UTC 
Thanks.  I think stable series is fine...