GNOME Bugzilla – Bug 694598
font color in the adding terminal (plugin "integrated terminal 3.3.4)
Last modified: 2019-03-23 20:57:21 UTC
Created attachment 237288 [details] an example picture of the Terminal color font In the bottom folder (adding terminal), the characters appear in white. But, as the background is in a light color (near white), it's quite difficult to read in that windaw. Sometimes, about 1 for 5, the characters are in black. The font color of the terminal bottom folder are not adjustable. And the settings of this adding window in gedit are not dependant of the setting of the Terminal application.
Trouble meet under Ubuntu 12.04 64bits & gedit 3.4.1 + additional gedit-plugins. The plugin involved is Integrated Terminal 3.3.4
Yes, this is because gnome-terminal wasn't ported to gsettings on the time the terminal plugin for gedit was ported. So at this point it is just a matter that we just forgot :)
Also reported downstream at https://bugs.launchpad.net/ubuntu/+source/gedit-plugins/+bug/1165131
Actually the right downstream bug report is https://bugs.launchpad.net/ubuntu/+source/gedit-plugins/+bug/946095
I've looked into this more and I now understand Ignacio's comment 2 above. Here's what's going on. Back in GNOME 2.32, both gedit and gnome-terminal stored settings in GConf. At that time the gedit terminal plugin looked at gnome-terminal's GConf settings to read the default profile information to find out what colors to use. You can see that code here: https://git.gnome.org/browse/gedit-plugins/tree/plugins/terminal/terminal.py?h=gnome-2-32 Then in GNOME 3.0 gedit ported over to GSettings, but gnome-terminal was still using GConf. The gedit terminal plugin could no longer easily look at the gnome-terminal profile info, so the terminal plugin just started using the default colors from the VTE terminal widget (which look poor, hence this bug). At that time the terminal plugin code added this FIXME line: def get_profile_settings(self): #FIXME return either the gnome-terminal settings or the gedit one return Gio.Settings.new("org.gnome.gedit.plugins.terminal") Now, finally, in GNOME 3.8 gnome-terminal has been ported to use GSettings: https://git.gnome.org/browse/gnome-terminal/tree/NEWS?h=gnome-3-8 So it should now be possible to fix this bug by having the terminal plugin read profile information from GSettings. I think this should be a high priority. Note that the downstream bug I linked to above says that over 50 people have reported being affected by this.
You're right on this. I'll try to have a look at this when I get some time.
That would be great - thanks!
Can you please test it?
Test what? As far as I can tell you haven't attached a patch or committed a change.
Adam see: https://git.gnome.org/browse/gedit-plugins/commit/?id=fbb0ffb7f563a5c9d7d64fc025d716e131abe157 https://git.gnome.org/browse/gedit-plugins/commit/?id=733421283b5f064e233bd915905a1ca16eff919c https://git.gnome.org/browse/gnome-themes-standard/commit/?id=2a04b0da69e1e352e6cbd84104dd4c52e46c0a3e
Oops - I was looking for a recent commit in gedit, not gedit-plugins. Silly me. OK, so I updated gedit-plugins to git master and tried this change. It doesn't work for me: the terminal still displays light gray on white. In terminal.py you're looking for a schema org.gnome.Terminal.ProfilesList but that doesn't exist on my machine. Also, I'm not sure whether GSettings is case-sensitive but you've capitalized "Terminal" and "Legacy" in your code, which seems odd - on my machine those GSettings keys are lowercase. I have gnome-terminal built from a recent git master, by the way.
Adam see: https://git.gnome.org/browse/gnome-terminal/tree/src/org.gnome.Terminal.gschema.xml.in#n81 while the path is lowercase the namespace is uppercase. In any case it should work... but I might have screwed up something.
OK, you're right about the capitalization - there's no problem there. I tested more. With your changes this works fine with Adwaita. With Ubuntu's default Ambiance theme, if I have "Use colors from system theme" checked in my terminal profile (which is the default) then I still see the unreadable light gray on white in the gedit terminal. If I uncheck that box and choose specific colors in the terminal profile then it works okay.
yes see this: https://git.gnome.org/browse/gnome-themes-standard/commit/?id=2a04b0da69e1e352e6cbd84104dd4c52e46c0a3e ambiance will need to get a patch.
OK - thanks for the information. I'll point the downstream ticket in this direction. Should we close this bug now since it works for Adwaita?
yeah, thanks a lot of the testing.
One more point: I think this would be well worth backporting to gedit-plugins 3.8.
done
great - thanks!
*** Bug 689842 has been marked as a duplicate of this bug. ***