After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694580 - Port EphySession to GTask
Port EphySession to GTask
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-24 10:37 UTC by Carlos Garcia Campos
Modified: 2013-02-24 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (12.82 KB, patch)
2013-02-24 10:37 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2013-02-24 10:37:04 UTC 
GSimpleAsyncResult is deprecated and GTask simplifies the code a bit.
Comment 1 Carlos Garcia Campos 2013-02-24 10:37:53 UTC 
Created attachment 237269 [details] [review]
Patch
Comment 2 Xan Lopez 2013-02-24 12:28:34 UTC 
Review of attachment 237269 [details] [review]:

Looks good to me, push it as long as all the unit tests still pass.