After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694577 - network: Add firewall zone field
network: Add firewall zone field
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-24 10:02 UTC by Matthias Clasen
Modified: 2013-03-06 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
helper functions (6.85 KB, patch)
2013-03-03 00:38 UTC, Matthias Clasen 		needs-work Details | Review
wifi (6.94 KB, patch)
2013-03-03 00:38 UTC, Matthias Clasen 		reviewed Details | Review
wired (8.67 KB, patch)
2013-03-03 00:39 UTC, Matthias Clasen 		reviewed Details | Review
vpn (6.59 KB, patch)
2013-03-03 00:39 UTC, Matthias Clasen 		reviewed Details | Review
fixup for the wifi patch (1.08 KB, patch)
2013-03-03 03:27 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2013-02-24 10:02:54 UTC 
nm-connection-editor has this field; it provides basic integration with the dynamic firewall configuration that is provided by firewalld.
Comment 1 Matthias Clasen 2013-03-03 00:38:32 UTC 
Created attachment 237859 [details] [review]
helper functions
Comment 2 Matthias Clasen 2013-03-03 00:38:57 UTC 
Created attachment 237860 [details] [review]
wifi
Comment 3 Matthias Clasen 2013-03-03 00:39:17 UTC 
Created attachment 237861 [details] [review]
wired
Comment 4 Matthias Clasen 2013-03-03 00:39:37 UTC 
Created attachment 237862 [details] [review]
vpn
Comment 5 Matthias Clasen 2013-03-03 03:27:21 UTC 
Created attachment 237863 [details] [review]
fixup for the wifi patch
Comment 6 Bastien Nocera 2013-03-04 12:08:51 UTC 
Review of attachment 237859 [details] [review]:

::: panels/network/connection-editor/firewall-helpers.c
@@ +88,3 @@
+        d->combo = combo;
+
+        g_dbus_connection_call (bus,

This is missing cancellable.
Comment 7 Bastien Nocera 2013-03-04 12:14:40 UTC 
Review of attachment 237860 [details] [review]:

::: panels/network/connection-editor/wifi-page.ui
@@ -114,3 @@
         <property name="entry_text_column">0</property>
         <property name="id_column">1</property>
-        <child internal-child="entry">

Losing some unrelated code here.

@@ -134,3 @@
         <property name="entry_text_column">0</property>
         <property name="id_column">1</property>
-        <child internal-child="entry">

And here.
Comment 8 Bastien Nocera 2013-03-04 12:16:01 UTC 
Review of attachment 237861 [details] [review]:

Fine.
Comment 9 Bastien Nocera 2013-03-04 12:30:46 UTC 
Review of attachment 237861 [details] [review]:

Fine.
Comment 10 Bastien Nocera 2013-03-04 12:31:27 UTC 
Review of attachment 237862 [details] [review]:

Fine.
Comment 11 Matthias Clasen 2013-03-05 02:47:06 UTC 
pushed with a cancellable. Sorry, I forgot to edit out the unrelated cleanup to the ui file.