GNOME Bugzilla – Bug 694562
default lock screen background
Last modified: 2013-05-02 19:48:01 UTC
We don't support lock screen backgrounds different from the desktop background currently. This will probably be available again at some point, but it isn't right now. Probably best to comment out this topic for now.
Could you please elaborate on which section you wanted commented out? Am unable to find it in session-screenlocks.page (which seems to be closest from what you are describing). Thanks!
This entire topic: http://help.gnome.org/admin/system-admin-guide/stable/lockscreenbackground.html.en
But lockscreenbackground.page has just that one topic. So, commenting it out would leave an empty page. Instead, can't we add a note(style="bug") to say that screen backgrounds different from the desktop background cannot be locked currently?
Created attachment 238305 [details] [review] The page describes that the feature is not currently supported via GUI but can be achieved with use of "override". Is this right? If so, I have added a note on the page that explains the same.
Created attachment 238306 [details] [review] Updated patch. The page describes that the feature is not currently supported via GUI but can be achieved with use of "override". Is this right? If so, I have added a note on the page that explains the same. Previous patch was not correct.
Review of attachment 238306 [details] [review]: It would be more appropriate to delete this page altogether because the help should reflect the release of GNOME that it is released alongside. When the setting is brought back, the instructions are likely to be completely different, so there is not much point stubbing the page. Remember to remove the page from Makefile.am when it is deleted.
Created attachment 238327 [details] [review] Removes lockscreenbackground.page and updates Makefile.am. Kat, done as asked. Please review and confirm if I should commit to master.
8:58 PM <kittykat> ingu: for bug 694562, did you check the links? 9:06 PM <ingu> kittykat: 694562 you mean what other pages link to the *.page i have deleted right? 9:07 PM <ingu> kittykat: if a page does link to the deleted page, what should I do? remove the link code? 9:08 PM <kittykat> ingu: remove the link and rewrite the sentence so that it doesn't mention the background Checked with a grep on pages that link to lockscreenbackground.page C git:(del-page) grep -R lockscreenbackground . ./lockscreenbackground.page: id="lockscreenbackground"> C git:(del-page) grep -nri "lockscreenbackground" . ./lockscreenbackground.page:3: id="lockscreenbackground"> There seems to be no other page that links to this page. So the patch uploaded is OK to commit to master I think, please confirm. Thanks.
Comment on attachment 238327 [details] [review] Removes lockscreenbackground.page and updates Makefile.am. You can also check links using 'yelp-check links <…>/*.page' :)
> You can also check links using 'yelp-check links <…>/*.page' :) Thank you, I will remember that :) Pushed to master in commit d41a819e992bd6085e29fbcc8d72ab04f9542284 available at https://git.gnome.org/browse/gnome-user-docs/commit/?id=d41a819e992bd6085e29fbcc8d72ab04f9542284 Closing bug now marking as RESOLVED ad FIXED.