GNOME Bugzilla – Bug 694475
Pressing space in the overview causes the search box to flash
Last modified: 2013-02-23 08:43:06 UTC
This seems to be a regression caused by removing the ability to search for a word preceded by spaces. The flash is distracting though. A better alternative would be to: 1. not focus the search box when space is pressed and the search box isn't already focused. 2. Keep the search box focused, but don't input a space character (this is what happens if the box is highlighted with nothing in it and enter is pressed).
Created attachment 237211 [details] [review] viewSelector: Don't focus search entry on whitespace We recently started to trim leading and trailing whitespace from the search string, and not to trigger a search when the resulting string was empty. However we still allow whitespace to trigger type-ahead-find, so that the key focus is moved briefly to the search entry and back to the stage, resulting in a disruptive flickering of the entry. Fix this by excluding whitespace from triggering type-ahead-find. (In reply to comment #0) > A better alternative would be to: > 1. not focus the search box when space is pressed and the search box isn't > already focused. > 2. Keep the search box focused, but don't input a space character (this is what (1) made slightly more sense to me.
Review of attachment 237211 [details] [review]: Looks good to me.
Attachment 237211 [details] pushed as fb0cf64 - viewSelector: Don't focus search entry on whitespace