After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694470 - Add setting for delayed tab loading, and use it to fix the session tests
Add setting for delayed tab loading, and use it to fix the session tests
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Gustavo Noronha (kov)
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-22 18:37 UTC by Gustavo Noronha (kov)
Modified: 2013-02-23 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add setting for delayed tab loading, and use it to fix the session tests (7.47 KB, patch)
2013-02-22 18:40 UTC, Gustavo Noronha (kov) 		committed Details | Review

Description Gustavo Noronha (kov) 2013-02-22 18:37:58 UTC 
SSIA
Comment 1 Gustavo Noronha (kov) 2013-02-22 18:40:00 UTC 
Created attachment 237208 [details] [review]
Add setting for delayed tab loading, and use it to fix the session tests
Comment 2 Xan Lopez 2013-02-23 12:43:20 UTC 
Review of attachment 237208 [details] [review]:

So if my theory was right this should make my patch 75da5fff3f4489dacf4ded6f012daa06af306709 not needed (in fact the tests should fail with it). Is that so? Things look good otherwise.
Comment 3 Gustavo Noronha (kov) 2013-02-23 19:56:47 UTC 
Yep, that's the case! If it looks fine to you I'll revert the change to expectations and push this.
Comment 4 Xan Lopez 2013-02-23 20:17:10 UTC 
Comment on attachment 237208 [details] [review]
Add setting for delayed tab loading, and use it to fix the session tests

Yeah, just push this and then revert my patch then. Thanks!
Comment 5 Gustavo Noronha (kov) 2013-02-23 20:43:44 UTC 
Comment on attachment 237208 [details] [review]
Add setting for delayed tab loading, and use it to fix the session tests

Pushed as b45047739e9ebc02200267a52295f24adf4ca668

I squashed the revert so that there would not be a new commit making the tests fail.