After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694457 - main: Remove auto-resize and zoom to video size
main: Remove auto-resize and zoom to video size
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 729322 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-02-22 15:22 UTC by Bastien Nocera
Modified: 2017-11-16 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main: Remove auto-resize and zoom to video size (22.40 KB, patch)
2013-02-22 15:22 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-02-22 15:22:43 UTC
.
Comment 1 Bastien Nocera 2013-02-22 15:22:45 UTC
Created attachment 237194 [details] [review]
main: Remove auto-resize and zoom to video size

Those will not make much sense anymore when we want Totem
to be maximised most of the time, as per the new designs.
Comment 2 Bastien Nocera 2013-03-06 16:57:02 UTC
Attachment 237194 [details] pushed as 866751f - main: Remove auto-resize and zoom to video size
Comment 3 Bastien Nocera 2014-05-01 12:50:13 UTC
*** Bug 729322 has been marked as a duplicate of this bug. ***
Comment 4 erusan 2014-05-03 00:34:15 UTC
The reasoning here seems very incomplete.

First, most people will not want to watch a video in a full screen window -- they'll want the video itself to be full screen, without decorations.

Second, you not only allow for arbitrary resizing of the video (rather than locking it to native video size), but you provide a toggle for zooming in versus preserving dimensions when the window is arbitrarily resized.

Third, and especially given the second point where arbitrary sizes are allowed, it makes perfect sense that users who are not watching a full screen video would instead prefer a 1:1 pixel ration, providing the most sharp and clear image possible for the video.

Strongly suggest reconsidering this decision. As it stands, the reasoning is faulty, and the implementation is inconsistent.
Comment 5 Andrei Dziahel 2014-05-05 10:04:49 UTC
I really do miss ability to view video as is (in 100%).
Comment 6 Bastien Nocera 2014-06-02 14:53:59 UTC
(In reply to comment #4)
> The reasoning here seems very incomplete.
> 
> First, most people will not want to watch a video in a full screen window --
> they'll want the video itself to be full screen, without decorations.

There's no practical difference between those 2.

> Second, you not only allow for arbitrary resizing of the video (rather than
> locking it to native video size), but you provide a toggle for zooming in
> versus preserving dimensions when the window is arbitrarily resized.
> 
> Third, and especially given the second point where arbitrary sizes are allowed,
> it makes perfect sense that users who are not watching a full screen video
> would instead prefer a 1:1 pixel ration, providing the most sharp and clear
> image possible for the video.
> 
> Strongly suggest reconsidering this decision. As it stands, the reasoning is
> faulty, and the implementation is inconsistent.

Inconsistent with what? Running videos in a small window still works, but it's not the main operating mode. Or rather, not the mode we want to support.

If this feature is necessary, consider writing (or getting somebody to write) a plugin to achieve that.
Comment 7 erusan 2014-06-03 15:40:41 UTC
>There's no practical difference between those 2.

There's no difference between a window with its header and controls showing, and a simple fullscreen video? I think you should reconsider that statement. Imagine you went to a theater and they decided to play the video with the header bar.

>Inconsistent with what?

With your "reasoning" that your vision is to have people watch videos in full screen. If that's the reason for removing 1:1 video resizing, as you've said it is, then that same reasoning says you shouldn't allow any arbitrary video resizing. Again, you even offer TWO OPTIONS for how the video should adapt to window resizing! So you say "We won't support it, because it doesn't fit our vision" (what about your users' vision?), but then you support it in other ways, including an option probably almost no one cares about -- the "Zoom In" option.

>If this feature is necessary, consider writing (or getting somebody to write) a
plugin to achieve that.

You *removed* it. How about just unremoving it?
Comment 8 erusan 2014-06-03 15:46:49 UTC
Who else might be involved in deciding GNOME's vision on this that might be able to be part of the conversation? McCann assures us that everyone can get involved, and that it's not just a few people making these decisions. Well, I'd like to see some evidence of that, and perhaps some other member of the GNOME team will give this some consideration. You hardly dealt with the reasoning I gave, and I can't imagine someone else wouldn't be able to better interact with the reasoning.

Unless, in fact, you're the only guy who makes these decisions for Totem.
Comment 9 Bastien Nocera 2014-09-18 20:30:18 UTC
(In reply to comment #7)
> >If this feature is necessary, consider writing (or getting somebody to write) a
> plugin to achieve that.
> 
> You *removed* it. How about just unremoving it?

It just doesn't work with the new UI. It breaks the overview. It's too easy to break in plenty of other ways (look at the logs to see how many times that feature was reimplemented, I would know).

(In reply to comment #8)
> Unless, in fact, you're the only guy who makes these decisions for Totem.

I am. Though I listen to specific use cases, and I try to find solutions to them. You already decided that the misfeature I just removed is the one you wanted. That's not going to work.
Comment 10 mike 2015-06-15 21:20:45 UTC
I just created a video that's 360x270. I load it in Totem. The window is way too large. I can't manually resize the window small enough to get 1:1 ratio. I can't tell Totem to automatically resize the window to 1:1 because you've decided to remove that functionality. 

Your reason for removing it "we want Totem to be maximised most of the time" is perhaps unfortunate poor wording but it comes across very badly. No one cares what you think about how the they should watch videos. Your opinion on how big you think people should have the window when they're watching a video should be as irrelevant to development of Totem as it is to the people who use it.


That there is only you making such decisions for Totem doesn't say anything good about the health of the project. (If you're the only person make decisions then who is the 'we' who has decided that they want Totem to be maximised most of the time?)
Comment 11 Alfonso Nishikawa 2016-08-21 22:02:44 UTC
@Bastien Nocera: You should update the documentation, since says the opposite you tell here: https://help.gnome.org/users/totem/stable/totem-usage.html.en#totem-usage-change-size
Comment 12 Bastien Nocera 2016-09-16 15:44:52 UTC
(In reply to Alfonso Nishikawa from comment #11)
> @Bastien Nocera: You should update the documentation, since says the
> opposite you tell here:
> https://help.gnome.org/users/totem/stable/totem-usage.html.en#totem-usage-
> change-size

I don't maintain the documentation. Please file a separate bug about it, it woefully outdated.
Comment 13 Vladislav 2017-11-16 11:33:35 UTC
Hello, I was surprised that 1:1 feature was removed.

After upgrading to Fedora 26 with gnome 3.24 I got performance and playback issues with my commonly used mplayer and hardware acceleration for Intel Integrated Graphics. 

I tried totem with gstreamer1-vaapi installed, and the hardware acceleration just works.

I'm developing web sites and make video screen recordings to demonstrate or discuss particular UI features. This videos usually are in HD (1280x720) or FullHD (1920x1080). 

So, before I send the screencast to the client I need to preview it.
And with Totem it's impossible to understand the perception of the video because, usually, the recorded web site interaction contains a lot of text that becomes distorted if not seeing in 1:1 size. I need all recorded web site elements to be crisp and sharp as I see them in reality.