After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694452 - totem-pl-parser should depend on libquvi
totem-pl-parser should depend on libquvi
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-02-22 14:36 UTC by Martin Pitt
Modified: 2013-02-23 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
3.8: Suggest libquvi for totem-pl-parser (1.30 KB, patch)
2013-02-22 14:40 UTC, Martin Pitt 		committed Details | Review

Description Martin Pitt 2013-02-22 14:36:10 UTC 
totem-pl-parser currently fails its RSS checks if the optional libquvi isn't installed (see bug 694438). So we might want to consider adding this as a suggests or even dependency?
Comment 1 Martin Pitt 2013-02-22 14:40:15 UTC 
Created attachment 237188 [details] [review]
3.8: Suggest libquvi for totem-pl-parser

I haven't done this before, is something like this patch enough?

It mostly seems to work here, except that it says "required" instead of optional:

$ jhbuild sysdeps totem-pl-parser
[...]
Required packages:
  System installed packages which are too old:
    (none)
  No matching system package installed:
    libquvi (libquvi.pc, required=0.4.0)
Optional packages: (JHBuild will build the missing packages)
  System installed packages which are too old:
    (none)
  No matching system package installed:

When I install libquvi-dev, it's happy and mentions it in "System installed packages which are new enough".
Comment 2 Javier Jardón (IRC: jjardon) 2013-02-22 17:12:34 UTC 
Comment on attachment 237188 [details] [review]
3.8: Suggest libquvi for totem-pl-parser

sure
Comment 3 Martin Pitt 2013-02-23 10:08:57 UTC 
Thanks, pushed.