After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694447 - Place names are illegible in Search Locations
Place names are illegible in Search Locations
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Search
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-22 13:43 UTC by sangu
Modified: 2013-02-28 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Search Locations (19.13 KB, image/png)
2013-02-22 13:43 UTC, sangu 		  Details
~/.config/user-dir.dirs (636 bytes, text/plain)
2013-02-22 13:47 UTC, sangu 		  Details
search: Unescape the names in Search Locations (2.09 KB, patch)
2013-02-28 15:06 UTC, Kalev Lember 		accepted-commit_now Details | Review

Description sangu 2013-02-22 13:43:03 UTC 
Created attachment 237177 [details]
Search Locations

Place names are illegible in Search Locations

LANG=ko_KR.UTF-8
Comment 1 sangu 2013-02-22 13:47:18 UTC 
Created attachment 237178 [details]
~/.config/user-dir.dirs

And 
$cat ~/.config/user-dirs.locale 
ko_KR
Comment 2 Bastien Nocera 2013-02-22 14:17:45 UTC 
get_bookmarks() uses a home-grown version of a bookmark parser instead of using GBookmarkFile.
Comment 3 Kalev Lember 2013-02-28 15:04:34 UTC 
GBookmarkFile wouldn't work here, because the ~/.config/gtk-3.0/bookmarks file isn't an xbel file. It's a simple home-grown format with one uri on each line (and an optional name). I believe we don't have a parser functionality for this exposed in neither glib / gtk+.

Attaching a patch which should fix up the home-grown parser to better unescape the file names.
Comment 4 Kalev Lember 2013-02-28 15:06:04 UTC 
Created attachment 237610 [details] [review]
search: Unescape the names in Search Locations

Instead of using g_path_get_basename() on raw URIs, use GFile functions
for getting the properly unescaped basenames of the files.
Comment 5 Cosimo Cecchi 2013-02-28 17:54:56 UTC 
Review of attachment 237610 [details] [review]:

Looks good to me, thanks.
Comment 6 Kalev Lember 2013-02-28 18:48:41 UTC 
Thanks, pushed to both master and gnome-3-8 branches.