After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694392 - Pinpoint does divide by zero when thumbnailing videos
Pinpoint does divide by zero when thumbnailing videos
Status: RESOLVED WONTFIX
Product: pinpoint
Classification: Other
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Pinpoint maintainer(s)
Pinpoint maintainer(s)
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2013-02-21 22:07 UTC by Stef Walter
Modified: 2018-08-17 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't divide by zero when thumbnailing videos (1.14 KB, patch)
2013-02-21 22:12 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2013-02-21 22:07:36 UTC 
When thumbnailing some videos, pinpoint does a divide by zero, like this:

Program received signal SIGFPE, Arithmetic exception.
0x000000000040ff4c in gst_video_thumbnailer_get_shot (
    location=0x2147e80 "/data/stuff/devconf-2013/realmd-talk/realm-discover-ad.webm", cancellable=0x1a59e70) at gst-video-thumbnailer.c:228
228	                    seekpos = (rand () % (duration / (GST_SECOND))) * GST_SECOND;
(gdb) p duration
$1 = 708000000
(gdb) p rand() % (duration / (1000000000))
Division by zero
(gdb) p duration / 1000000000
$2 = 0
Comment 1 Stef Walter 2013-02-21 22:11:22 UTC 
This bug causes both the presenter tool, or export to pdf to crash. Will attach a patch, although you may want to fix this differently.
Comment 2 Stef Walter 2013-02-21 22:12:57 UTC 
Created attachment 237118 [details] [review]
Don't divide by zero when thumbnailing videos

Just pick a point halfway through the video, if a divide by zero
would have occurred.
Comment 3 Tobias Mueller 2014-05-25 06:37:08 UTC 
I seems that the patch has landed as 09b77c924496d5f4d38119de8bac0377cbdfaa7d. Hence I am closing.
Comment 4 André Klapper 2018-08-17 19:57:52 UTC 
pinpoint is not under active development anymore since 2015.
Its codebase has been archived:
https://gitlab.gnome.org/Archive/pinpoint/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.