GNOME Bugzilla – Bug 694371
Folder popups are truncated at the top if they don't fit
Last modified: 2013-06-05 13:28:16 UTC
Created attachment 237060 [details] Screenshot If the source folder is too high in the view, and the folder popup too large, popups can be truncated.
*** Bug 695251 has been marked as a duplicate of this bug. ***
*** Bug 695862 has been marked as a duplicate of this bug. ***
Created attachment 238921 [details] [review] appDisplay: Use a custom LayoutManager for the AllView stack ClutterBinLayout uses the maximum width/height of all children in size requests and positions children according to the expand/align properties. This means that the vertical position of folder popups is not considered in size requests, so if the main view is smaller than a folder popup's height and offset, the popup will be truncated and/or mispositioned. Fix those cases by using a custom LayoutManager that behaves like ClutterFixedLayout for height requests and like ClutterBinLayout otherwise.
Very visible issue in a prominent new feature. Should probably get that fix in, for 3.8
(In reply to comment #4) > Very visible issue in a prominent new feature. Not sure I'd call it very visible - it should only be an issue where either - there's only a very small number of application launchers in the main view (ideally that's the case on fresh installs, but how many distro actually do that?) - users mess with GSettings to turn more categories into folders
Review of attachment 238921 [details] [review]: Looks good. ::: js/ui/appDisplay.js @@ +170,3 @@ + child = child.get_next_sibling()) { + let childY = child.y; + let [childMin, childNatural] = child.get_preferred_height (forWidth); Remove the whitespace.
Attachment 238921 [details] pushed as 499ae60 - appDisplay: Use a custom LayoutManager for the AllView stack
This patch did not solve the bug for me, and I expect it is because you're not overriding size_allocate, so the extra space you request is not going anywhere useful.
(In reply to comment #8) > This patch did not solve the bug for me, and I expect it is because you're not > overriding size_allocate Mmmh, I tested with all categories turned into app folders - probably some local patch then, I'll look into it tomorrow ...
Created attachment 239067 [details] [review] appDisplay: Expand AllView If the view doesn't fill the available screen, content should still start at the top rather than the center - not least the positioning code for folder popups assumes that, so set the appropriate expand flags. ^^^ So that's the culprit, the local patch that made it work for me ...
Nope, still truncated. Btw, in my case I just turned Games into a folder, so the outer content is higher than the folder, but the folder is positioned partly outside the allocation, because the folder icon is too close to the top.
(In reply to comment #11) > Nope, still truncated. > Btw, in my case I just turned Games into a folder, so the outer content is > higher than the folder, but the folder is positioned partly outside the > allocation, because the folder icon is too close to the top. I'm unable to reproduce this. I've tried with "Games" (both en_US and it_IT) and "Others" renamed to "Aaaa" (so it shows up at the very top), it works as expected in all cases.
Created attachment 239446 [details] Closing button clipped Encountered on gnome-shell-3.7.92-2.fc19.x86_64
probably too late for cosmetic fixes like this now; we should pick this up for 3.8.1
*** Bug 696910 has been marked as a duplicate of this bug. ***
Created attachment 244426 [details] [review] appDisplay: Fix cut-off folders in All view We already take care of growing the view if open folders overlap at the bottom, however folder popups may still end up being cut off when opening above the source icon - if the popup is high enough, its y coordinate will be negative and therefore outside the parent's allocation. To fix, we can either make sure that folders pop up below their source icon in that case, or adjust the parent grid's position as necessary while a folder is open. This implements the latter.
Created attachment 244441 [details] [review] appDisplay: Also account for folder popup's close buttons As the close button of folder popups overlaps at the top, it ends up being cut off if the folder is located at the very top of the view. Fix this glitch by taking the button's overlap into account in that case.
*** Bug 700658 has been marked as a duplicate of this bug. ***
Review of attachment 244426 [details] [review]: Finally got around to test this, it fixed my problem. ::: js/ui/appDisplay.js @@ +708,3 @@ + set parentOffset(offset) { + this._parentOffset = offset; + }, If you do nothing in the setter, just avoid it an set parentOffset as a data property.
Review of attachment 244441 [details] [review]: Ok
Attachment 239067 [details] pushed as b799e8c - appDisplay: Expand AllView Attachment 244426 [details] pushed as d8d0aff - appDisplay: Fix cut-off folders in All view Attachment 244441 [details] pushed as 0eba0f8 - appDisplay: Also account for folder popup's close buttons
*** Bug 701648 has been marked as a duplicate of this bug. ***