After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694336 - messageTray: Fix warning when opening the tray
messageTray: Fix warning when opening the tray
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-21 04:46 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-21 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Fix warning when opening the tray (1.26 KB, patch)
2013-02-21 04:46 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-21 04:46:09 UTC 
As the tray hover handler will call _cancelTrayDwell, we need to
ensure this variable is initialized even if tray dwelling isn't.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-21 04:46:11 UTC 
Created attachment 237014 [details] [review]
messageTray: Fix warning when opening the tray
Comment 2 drago01 2013-02-21 08:24:34 UTC 
Review of attachment 237014 [details] [review]:

Makes more sense to initialize it in _init then.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-21 16:41:16 UTC 
Attachment 237014 [details] pushed as 7b06d34 - messageTray: Fix warning when opening the tray
Comment 4 drago01 2013-02-21 16:49:33 UTC 
(In reply to comment #3)
> Attachment 237014 [details] pushed as 7b06d34 - messageTray: Fix warning when opening the
> tray

Next time when you decide to ignore review comments leave a comment in the bug so others can understand why.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-21 16:53:58 UTC 
It was commited by mistake, sorry. Backed out now.
Comment 6 drago01 2013-02-21 16:55:24 UTC 
(In reply to comment #5)
> It was commited by mistake, sorry. Backed out now.

Just move it to init and be done with it.