GNOME Bugzilla – Bug 694326
startup animation during shell restarts needs to be removed or improved
Last modified: 2013-03-02 22:44:46 UTC
I don't know if this is hard to implement; I think the new zoom out animation of the login screen to the desktop should only be performed after log in, and not when you e.g. restart the shell from the run dialog or when it's automatically respanwed after a crash.
we could probably look at org.gnome.SessionManager.IsSessionRunning I wonder if we should try to have some sort of transition for controlled restarts though.
I talked to Jon about this a bit. At a very minimum we should 1) make the animation more subtle. a) Start from a .5 scale, not a 0 scale. b) add a fade up. 2) show the system noise texture below the animation, not the undecorated windows Also, I talked to Jasper about this a bit. We should 3) refrain from showing window actor that touch secondary monitors until the animation is done and fade them in. Or we could go with the original proposal and not do any sort of animation at all.
(i'm going to post some patches that apply on top of the patches in bug 694321)
Created attachment 237098 [details] [review] main: put noise texture below startup animation, not still frames Right now we take a still frame of the desktop before showing the start up animation. This gives us an animation over what was there before startup. That's not actually desirable when restarting the shell. We don't want to animate over undecorated windows, we really want to animate over the noise texture. This commit drops the still frames in favor of the noise texture.
Created attachment 237099 [details] [review] layout: tweak startup animation Following designer feedback, this commit makes the startup animation a little more subtle.
Dropping the GLib.idle_add means that it's possible to run the animation while other I/O is going on. I think we should still keep it.
Created attachment 237105 [details] [review] main: put noise texture below startup animation, not still frames Right now we take a still frame of the desktop before showing the start up animation. This gives us an animation over what was there before startup. That's not actually desirable when restarting the shell. We don't want to animate over undecorated windows, we really want to animate over the noise texture. This commit drops the still frames in favor of the noise texture.
Created attachment 237106 [details] [review] layout: tweak startup animation Following designer feedback, this commit makes the startup animation a little more subtle.
Review of attachment 237105 [details] [review]: OK. ::: js/ui/main.js @@ +195,3 @@ + layoutManager.connect('startup-prepared', + Lang.bind(this, function() { Remove the bind. There is no "this" here.
Review of attachment 237105 [details] [review]: Well, you don't remove StillFrame from background.js...
Review of attachment 237106 [details] [review]: OK.
Attachment 237105 [details] pushed as 570fc68 - main: put noise texture below startup animation, not still frames Attachment 237106 [details] pushed as 1cbb8b9 - layout: tweak startup animation