After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694323 - Language list contents are not centered
Language list contents are not centered
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-20 23:45 UTC by Cosimo Cecchi
Modified: 2013-02-26 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (22.24 KB, image/png)
2013-02-20 23:45 UTC, Cosimo Cecchi 		  Details
common: fix language chooser to be centered (2.18 KB, patch)
2013-02-21 00:06 UTC, William Jon McCann 		reviewed Details | Review
region: make format chooser centered (1.67 KB, patch)
2013-02-21 00:06 UTC, William Jon McCann 		reviewed Details | Review
common: fix language chooser to be centered (2.83 KB, patch)
2013-02-25 17:23 UTC, William Jon McCann 		committed Details | Review
region: make format chooser centered (1.83 KB, patch)
2013-02-25 17:23 UTC, William Jon McCann 		committed Details | Review

Description Cosimo Cecchi 2013-02-20 23:45:37 UTC 
See attached screenshot - the last item (the dots) are centered, but the other languages in the list are not.
Comment 1 Cosimo Cecchi 2013-02-20 23:45:56 UTC 
Created attachment 236994 [details]
screenshot
Comment 2 William Jon McCann 2013-02-21 00:06:30 UTC 
Created attachment 236998 [details] [review]
common: fix language chooser to be centered
Comment 3 William Jon McCann 2013-02-21 00:06:32 UTC 
Created attachment 236999 [details] [review]
region: make format chooser centered
Comment 4 Bastien Nocera 2013-02-21 00:12:34 UTC 
Review of attachment 236998 [details] [review]:

Looks good otherwise.

::: panels/common/cc-language-chooser.c
@@ +150,1 @@
                 gtk_image_set_from_icon_name (GTK_IMAGE (check), "object-select-symbolic", GTK_ICON_SIZE_MENU);

You could just always set it as it would be hidden in the normal case.
Comment 5 Bastien Nocera 2013-02-21 00:13:17 UTC 
Review of attachment 236999 [details] [review]:

::: panels/region/cc-format-chooser.c
@@ +238,2 @@
         check = gtk_image_new ();
+        gtk_widget_set_no_show_all (check, TRUE);

You could set the icon name here, as you're hiding it when not selected.
Comment 6 William Jon McCann 2013-02-25 17:23:46 UTC 
Created attachment 237372 [details] [review]
common: fix language chooser to be centered
Comment 7 William Jon McCann 2013-02-25 17:23:48 UTC 
Created attachment 237373 [details] [review]
region: make format chooser centered