After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694293 - Plug some small leaks
Plug some small leaks
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-20 18:04 UTC by fakey
Modified: 2013-02-25 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Plug some small leaks (5.20 KB, patch)
2013-02-20 18:04 UTC, fakey 		committed Details | Review
More unrefs for rb_display_page_delete_thyself calls (4.16 KB, patch)
2013-02-25 19:18 UTC, fakey 		none Details | Review

Description fakey 2013-02-20 18:04:39 UTC 
Created attachment 236963 [details] [review]
Plug some small leaks

There are a few very small minor leaks found using valgrind while trying to investigate https://bugzilla.gnome.org/show_bug.cgi?id=677738 and https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1031449. Still didn't have any luck finding the major culprits though.
Comment 1 Jonathan Matthew 2013-02-22 23:58:07 UTC 
pushed as commit f95589b, thanks.

There are more cases where things need an unref after rb_display_page_delete_thyself, which I'll probably get to soon unless you want to fix them too.
Comment 2 fakey 2013-02-25 19:18:09 UTC 
Created attachment 237381 [details] [review]
More unrefs for rb_display_page_delete_thyself calls

I wasn't able to understand and fix a lot of the rb_display_page_delete_thyself related leaks, but here are a few fixes to the easy ones. If I remember correctly, I couldn't actually test the visualizer or the fm-radio plugin changes, so you might want to remove them from the patch until it can be tested properly.