After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694240 - background: don't call destroy() from the destroy handler
background: don't call destroy() from the destroy handler
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-20 05:06 UTC by Cosimo Cecchi
Modified: 2013-02-25 04:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: don't call destroy() from the destroy handler (818 bytes, patch)
2013-02-20 05:06 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-02-20 05:06:36 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2013-02-20 05:06:39 UTC 
Created attachment 236887 [details] [review]
background: don't call destroy() from the destroy handler

We're calling destroy() in a callback of the destroy handler, which
results in an X server crash at login.
Comment 2 Cosimo Cecchi 2013-02-20 05:08:31 UTC 
Attachment 236887 [details] pushed as 9ebb805 - background: don't call destroy() from the destroy handler

Argh, pushed by mistake while pushing another patch.
Feel free to revert if this is not correct.
Comment 3 Ray Strode [halfline] 2013-02-25 04:06:59 UTC 
(this was right, thanks for the fix)