After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694162 - Memory leaks due to extra ref in gtk_ui_manager_buildable_add_child()
Memory leaks due to extra ref in gtk_ui_manager_buildable_add_child()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-19 12:09 UTC by Milan Crha
Modified: 2013-02-20 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk patch (409 bytes, patch)
2013-02-19 12:09 UTC, Milan Crha 		committed Details | Review

Description Milan Crha 2013-02-19 12:09:18 UTC 
While chasing bug #674236, I found out, after Tristan's help and ideas, an extra g_object_ref() call in gtk_ui_manager_buildable_add_child(). It's  making the object leaking, because the called gtk_ui_manager_insert_action_group() refs the child again.
Comment 1 Milan Crha 2013-02-19 12:09:52 UTC 
Created attachment 236755 [details] [review]
gtk patch

for gtk+;

Removes the extra g_object_ref() call.
Comment 2 Cosimo Cecchi 2013-02-19 15:31:19 UTC 
Review of attachment 236755 [details] [review]:

Looks correct to me.
Comment 3 Tristan Van Berkom 2013-02-20 09:22:27 UTC 
Comment on attachment 236755 [details] [review]
gtk patch

Committing this patch on Milan's behalf.
Comment 4 Milan Crha 2013-02-20 09:59:23 UTC 
Thanks a lot, Tristan.