After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694150 - Don't ask for samba password on non-samba servers
Don't ask for samba password on non-samba servers
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-19 09:23 UTC by Marek Kašík
Modified: 2013-02-19 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't ask for samba password if not needed (994 bytes, patch)
2013-02-19 11:57 UTC, Marek Kašík 		committed Details | Review

Description Marek Kašík 2013-02-19 09:23:22 UTC 
New printer dialog asks for password for samba server even if server on entered address doesn't run samba server.

I'm working on fix for this.
Comment 1 Marek Kašík 2013-02-19 11:57:41 UTC 
Created attachment 236754 [details] [review]
don't ask for samba password if not needed

Attached patch fixes this bug. It is a trivial check of errno for EACCES.
Comment 2 Bastien Nocera 2013-02-19 13:29:12 UTC 
Review of attachment 236754 [details] [review]:

Looks fine.
Comment 3 Marek Kašík 2013-02-19 13:37:16 UTC 
Comment on attachment 236754 [details] [review]
don't ask for samba password if not needed

Thank you very much for the quick review.