Created attachment 236613 [details] [review]
OverviewControl: simplify code to add bottom padding

Review of attachment 236613 [details] [review]:

::: data/theme/gnome-shell.css
@@ +630,3 @@
 #overview {
     spacing: 24px;
+    padding-bottom: 30px;

We use 32px everywhere else...

::: js/ui/overviewControls.js
@@ +300,3 @@
+    _init: function(dash, thumbnails, viewSelector) {
+        this.dashSlider = new DashSlider(dash);
+        this.thumbnailsSlider = new ThumbnailsSlider(thumbnails);

Please either keep the sliders private and use dashActor as before, or also rename _dashSlider to dashSlider below (I'd prefer the former).

Created attachment 236624 [details] [review]
OverviewControl: simplify code to add bottom padding

All the complexity with a custom actor and a generic container was
just to add some padding below the overview controls. Remove that,
and use CSS instead.

Review of attachment 236624 [details] [review]:

Looks good to me, thanks.

Attachment 236624 [details] pushed as a187111 - OverviewControl: simplify code to add bottom padding

Won't this break centering in Large Text mode?

Not really, as even before the bottom padding wasn't exactly the same, since it didn't have the spacing added by the overview between the panel and the entry bin, and the entry bin and the view group.
I think overall this allows us more flexibility while keeping the code simple.
If we need to revisit this in the future when we globally fine-tweak overview paddings again, I'd rather start from a clean state.

Alright, fine.