GNOME Bugzilla – Bug 694092
Clipping is not reset correctly when workspace switcher is hidden
Last modified: 2013-09-14 16:32:03 UTC
See attached screencast. This happens only if you have two workspaces when you enter the overview, and you move your windows to have one, which hides the chooser.
The attachment was too big for bugzilla, so the screencast is temporarily hosted at http://people.gnome.org/~gcampagna/Screencast%20da%2018-02-2013%2015:48:10.webm
Yeah, I noticed this too. It's because of [1] - when we start with an extended thumbnails slider, the clip will not be updated until next time the overview is entered. Not sure what's the best way to solve this. As far as I understand, the clip is only there to avoid the workspaces view to shine through when moving between workspaces. Perhaps the clip should always be set to the width of the primary monitor instead, and just positioned vertically. [1] http://git.gnome.org/browse/gnome-shell/tree/js/ui/workspacesView.js#n84
Created attachment 238538 [details] [review] WorkspacesView: set the clip when setting the geometry Fixes clipping the windows when you open the overview with the workspace switcher expanded and then shrink it. Now, not clipping horizontally as you propose might have a better performance, but I didn't want to complicate the code to account for monitor geometry changes. We might fix it better in 3.10.
Hard code freeze ping!
Attachment 238538 [details] pushed as d3ab367 - WorkspacesView: set the clip when setting the geometry
Sorry, I pushed this by mistake.
(In reply to comment #4) > Hard code freeze ping! (one cycle later) ... Do we still need this?
The original reproducer doesn't work anymore, let's call this fixed.