GNOME Bugzilla – Bug 694067
pygtkcompat: Make it more compatible
Last modified: 2014-08-06 04:53:03 UTC
This ticket can be used for tracking simple patches to the pygtkcompat layer.
Created attachment 236559 [details] [review] pygtkcompat: Add Gtk.Window.set_geometry_hints which accepts keyword arguments Monkey patch a keyword argument version of set_geometry_hints onto Gtk.Window. This version is compatible with pygtk and takes keywords instead of a Gdk.Geometry and Gdk.GeometryMask.
Created attachment 236560 [details] [review] pygtkcompat: Add Widget.window, scroll_to_mark, and window methods Fix gi.pygtkcompat attempting relative import in Python < 3.0. Add Gtk.Widget.window property which uses get_window() Add Gtk.TextView.scroll_to_mark with defaults Add Gtk.window_list_toplevels and Gtk.window_set_default_icon_name
Comment on attachment 236560 [details] [review] pygtkcompat: Add Widget.window, scroll_to_mark, and window methods What was the error without using absolute_import? We have some test case coverage of pygtkcompat and I didn't see it fail for 2.7?
(In reply to comment #3) > (From update of attachment 236560 [details] [review]) > What was the error without using absolute_import? We have some test case > coverage of pygtkcompat and I didn't see it fail for 2.7? >>> import gi.pygtkcompat Traceback (most recent call last):
+ Trace 231571
from pygtkcompat import (enable,
It is tries to import enable from itself because the absolute module has the same name. It looks like the tests were changed to use the absolute pygtkcompat so this wasn't showing up.
Comment on attachment 236559 [details] [review] pygtkcompat: Add Gtk.Window.set_geometry_hints which accepts keyword arguments Attachment 236559 [details] pushed as e8e2bbe - pygtkcompat: Add Gtk.Window.set_geometry_hints which accepts keyword arguments
Comment on attachment 236560 [details] [review] pygtkcompat: Add Widget.window, scroll_to_mark, and window methods Attachment 236560 [details] pushed as 9f8258c - pygtkcompat: Add Widget.window, scroll_to_mark, and window methods
No point in keeping this open, we can log individual tickets as more things come up.